Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1503)

Issue 16087006: Revert "Revert 202751 "Change RulesRegistryService to use ProfileKeyedAPI."" (Closed)

Created:
7 years, 6 months ago by Dan Beam
Modified:
7 years, 6 months ago
CC:
chromium-reviews, Aaron Boodman, sail+watch_chromium.org, chromium-apps-reviews_chromium.org
Visibility:
Public.

Description

Revert "Revert 202751 "Change RulesRegistryService to use ProfileKeyedAPI."" This reverts commit 4868bcc588c835a2d6be88d11da0ab0009971d85. Change RulesRegistryService to use ProfileKeyedAPI. Patch by Patrick Riordan <patrickriordan177@gmail.com>;. BUG=179951 R=patrickriordan177@gmail.com,yoz@chromium.org

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -60 lines) Patch
M chrome/browser/extensions/api/declarative/declarative_api.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/extensions/api/declarative/declarative_apitest.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/extensions/api/declarative/rules_registry_service.h View 4 chunks +19 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/declarative/rules_registry_service.cc View 3 chunks +17 lines, -1 line 0 comments Download
M chrome/browser/extensions/extension_system.h View 7 chunks +0 lines, -12 lines 0 comments Download
M chrome/browser/extensions/extension_system.cc View 4 chunks +0 lines, -21 lines 0 comments Download
M chrome/browser/extensions/tab_helper.h View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/extensions/tab_helper.cc View 3 chunks +5 lines, -9 lines 0 comments Download
M chrome/browser/extensions/test_extension_system.h View 2 chunks +0 lines, -2 lines 0 comments Download
M chrome/browser/extensions/test_extension_system.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/profiles/off_the_record_profile_impl.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/profiles/off_the_record_profile_impl_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
Dan Beam
7 years, 6 months ago (2013-05-29 23:26:23 UTC) #1
Patrick Riordan
From the stack trace it seems like RulesRegistryService::Get(profile_) returned NULL and not content_rules_registry(). I'm not ...
7 years, 6 months ago (2013-05-30 00:07:47 UTC) #2
Dan Beam
On 2013/05/30 00:07:47, Patrick Riordan wrote: > From the stack trace it seems like RulesRegistryService::Get(profile_) ...
7 years, 6 months ago (2013-05-30 00:11:06 UTC) #3
Patrick Riordan
On 2013/05/30 00:07:47, Patrick Riordan wrote: > From the stack trace it seems like RulesRegistryService::Get(profile_) ...
7 years, 6 months ago (2013-05-30 00:11:32 UTC) #4
Patrick Riordan
7 years, 6 months ago (2013-05-30 00:24:10 UTC) #5
On 2013/05/30 00:11:06, Dan Beam wrote:
> On 2013/05/30 00:07:47, Patrick Riordan wrote:
> > From the stack trace it seems like RulesRegistryService::Get(profile_)
> > returned NULL and not content_rules_registry().
> > I'm not sure if that's it, but could you wait to commit until I investigate
> > further?
> 
> sure, you're more than welcome to reland your own patch as well, just didn't
> want this to get lost...

I appreciate the help, I've just had some similar problems with different tests
when making this patch and I want to be sure that they're completely fixed
before
committing it. I thought I had worked them out but clearly not.

I'll fix it and re-revert it.

Powered by Google App Engine
This is Rietveld 408576698