Issue 16085007: Use an explicitly-sized int type across the IPC boundary.

Issue 16085007: Use an explicitly-sized int type across the IPC boundary. (Closed)

Created:
7 years, 6 months ago by palmer

Modified:
7 years, 6 months ago

Reviewers:
sky, nasko

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Use an explicitly-sized int type across the IPC boundary. BUG=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=203861

Patch Set 2 : Missed a delcaration in the .cc. #

Patch Set 3 : Fix style nit. #

Patch Set 4 : uint32 instead of _t, for Windows. #

Patch Set 5 : uint32 instead of _t, for Windows. #

Created: 7 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -6 lines)			Patch
M	content/browser/renderer_host/render_message_filter.h	View	1 2 3	1 chunk	+1 line, -1 line	0 comments	Download
M	content/browser/renderer_host/render_message_filter.cc	View	1 2 3	1 chunk	+1 line, -1 line	0 comments	Download
M	content/browser/renderer_host/render_widget_helper.h	View	1 2 3 4	1 chunk	+1 line, -1 line	0 comments	Download
M	content/browser/renderer_host/render_widget_helper.cc	View	1 2 3 4	1 chunk	+3 lines, -2 lines	0 comments	Download
M	content/common/view_messages.h	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

sky

LGTM https://codereview.chromium.org/16085007/diff/1/content/browser/renderer_host/render_widget_helper.cc File content/browser/renderer_host/render_widget_helper.cc (right): https://codereview.chromium.org/16085007/diff/1/content/browser/renderer_host/render_widget_helper.cc#newcode352 content/browser/renderer_host/render_widget_helper.cc:352: uint32_t size, bool cache_in_browser, TransportDIB::Handle* result) { nit: ...

7 years, 6 months ago (2013-05-31 21:51:20 UTC) #2

palmer

https://codereview.chromium.org/16085007/diff/1/content/browser/renderer_host/render_widget_helper.cc File content/browser/renderer_host/render_widget_helper.cc (right): https://codereview.chromium.org/16085007/diff/1/content/browser/renderer_host/render_widget_helper.cc#newcode352 content/browser/renderer_host/render_widget_helper.cc:352: uint32_t size, bool cache_in_browser, TransportDIB::Handle* result) { On 2013/05/31 ...

7 years, 6 months ago (2013-05-31 22:05:18 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/palmer@chromium.org/16085007/10001

7 years, 6 months ago (2013-06-03 17:39:05 UTC) #5

Message was sent while issue was closed.

Change committed as 203861

Expand Messages | Collapse Messages