Issue 16082002: Fix the Android implementation of SelectFile() SEGV when params is NULL.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 16082002: Fix the Android implementation of SelectFile() SEGV when params is NULL. (Closed)

Created:
7 years, 7 months ago by kouhei (in TOK)

Modified:
7 years, 6 months ago

Reviewers:
Ben Goodger (Google)

CC:
chromium-reviews, haraken

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

Fix the Android implementation of SelectFile() SEGV when params is NULL. The comments on the SelectFile() method says it is safe to pass NULL to the arg params. However, this is not true on the Android implementation of the function, SelectFileDialogImpl::SelectFileImpl() for Android. BUG=None Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=202816