Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(438)

Issue 16081007: Introduce toHTMLInputElement(Node*), and use it. (Closed)

Created:
7 years, 6 months ago by tkent
Modified:
7 years, 6 months ago
Reviewers:
inferno
CC:
blink-reviews, aboxhall, eae+blinkwatch, leviw+renderwatch, dglazkov+blink, dmazzoni, apavlov+blink_chromium.org, adamk+blink_chromium.org, jchaffraix+rendering, darktears, Nate Chapin, gavinp+loader_chromium.org
Visibility:
Public.

Description

Introduce toHTMLInputElement(Node*), and use it. We still have Node::toInputElement. It should be removed in a future patch. BUG=none TEST=none; no behavior changes. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=151811

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+82 lines, -75 lines) Patch
M Source/WebKit/chromium/src/ContextMenuClientImpl.cpp View 2 chunks +4 lines, -6 lines 0 comments Download
M Source/WebKit/chromium/src/DOMUtilitiesPrivate.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/WebKit/chromium/src/EditorClientImpl.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M Source/WebKit/chromium/src/WebInputElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/WebKit/chromium/src/WebPageSerializer.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M Source/WebKit/chromium/src/WebSearchableFormData.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/WebKit/chromium/src/WebViewImpl.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/accessibility/AccessibilityMediaControls.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M Source/core/accessibility/AccessibilityNodeObject.cpp View 13 chunks +15 lines, -19 lines 0 comments Download
M Source/core/accessibility/AccessibilityRenderObject.cpp View 7 chunks +7 lines, -7 lines 0 comments Download
M Source/core/accessibility/AccessibilitySlider.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/resolver/StyleResolver.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/Node.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/editing/FrameSelection.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/editing/ReplaceSelectionCommand.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLFormControlElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLFormElement.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/html/HTMLInputElement.h View 1 chunk +16 lines, -0 lines 0 comments Download
M Source/core/html/RadioInputType.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/html/shadow/TextControlInnerElements.cpp View 7 chunks +7 lines, -7 lines 0 comments Download
M Source/core/html/shadow/TextFieldDecorationElement.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M Source/core/loader/FormSubmission.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/page/Chrome.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/page/EventHandler.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/HitTestResult.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/rendering/RenderButton.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/RenderFileUploadControl.cpp View 5 chunks +6 lines, -6 lines 0 comments Download
M Source/core/rendering/RenderImage.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
tkent
7 years, 6 months ago (2013-06-05 03:09:48 UTC) #1
inferno
lgtm
7 years, 6 months ago (2013-06-05 03:40:43 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tkent@chromium.org/16081007/1
7 years, 6 months ago (2013-06-05 06:31:06 UTC) #3
commit-bot: I haz the power
7 years, 6 months ago (2013-06-05 06:37:48 UTC) #4
Message was sent while issue was closed.
Change committed as 151811

Powered by Google App Engine
This is Rietveld 408576698