Issue 16081002: Add SearchOperationTest for drive::file_system::SearchOperation.

Issue 16081002: Add SearchOperationTest for drive::file_system::SearchOperation. (Closed)

Created:
7 years, 7 months ago by kinaba

Modified:
7 years, 7 months ago

Reviewers:
commit-bot: I haz the power, hashimoto

CC:
chromium-reviews, nkostylev+watch_chromium.org, tzik+watch_chromium.org, oshima+watch_chromium.org, tfarina, kinuko+watch, stevenjb+watch_chromium.org, davemoore+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Add SearchOperationTest for drive::file_system::SearchOperation. BUG=244110 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=202416

Patch Set 3 : Rebase #

Created: 7 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+114 lines, -99 lines)			Patch
A	chrome/browser/chromeos/drive/file_system/search_operation_unittest.cc	View	1	1 chunk	+113 lines, -0 lines	0 comments	Download
M	chrome/browser/chromeos/drive/file_system_unittest.cc	View	1 2	2 chunks	+0 lines, -99 lines	0 comments	Download
M	chrome/chrome_tests_unit.gypi	View		1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 8 (0 generated)

Expand Messages | Collapse Messages

hashimoto

https://codereview.chromium.org/16081002/diff/1/chrome/browser/chromeos/drive/file_system/search_operation_unittest.cc File chrome/browser/chromeos/drive/file_system/search_operation_unittest.cc (right): https://codereview.chromium.org/16081002/diff/1/chrome/browser/chromeos/drive/file_system/search_operation_unittest.cc#newcode52 chrome/browser/chromeos/drive/file_system/search_operation_unittest.cc:52: EXPECT_EQ(base::FilePath(kExpectedResults[i].path), Shouldn't this be FromUTF8Unsafe()? Also, how about comparing ...

7 years, 7 months ago (2013-05-27 03:15:50 UTC) #2

kinaba

https://codereview.chromium.org/16081002/diff/1/chrome/browser/chromeos/drive/file_system/search_operation_unittest.cc File chrome/browser/chromeos/drive/file_system/search_operation_unittest.cc (right): https://codereview.chromium.org/16081002/diff/1/chrome/browser/chromeos/drive/file_system/search_operation_unittest.cc#newcode52 chrome/browser/chromeos/drive/file_system/search_operation_unittest.cc:52: EXPECT_EQ(base::FilePath(kExpectedResults[i].path), On 2013/05/27 03:15:51, hashimoto wrote: > Shouldn't this ...

7 years, 7 months ago (2013-05-27 03:35:16 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kinaba@chromium.org/16081002/11001

7 years, 7 months ago (2013-05-27 08:47:56 UTC) #5

commit-bot: I haz the power

Retried try job too often on linux_chromeos for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chromeos&number=118642

7 years, 7 months ago (2013-05-27 10:53:44 UTC) #6

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kinaba@chromium.org/16081002/11001

7 years, 7 months ago (2013-05-27 11:01:42 UTC) #7

Message was sent while issue was closed.

Change committed as 202416

Expand Messages | Collapse Messages