Issue 16080002: Fixed cropping above the arrows in Files.app.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 16080002: Fixed cropping above the arrows in Files.app. (Closed)

Created:
7 years, 7 months ago by mtomasz

Modified:
7 years, 6 months ago

Reviewers:
yoshiki, commit-bot: I haz the power

CC:
chromium-reviews, rginda+watch_chromium.org, arv+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Fixed cropping above the arrows in Files.app. Cropping over the right arrow was malfunctioning because of a bug in coordinates calculation. The mouse move handler was interpreting relative position (here on the arrow) instead of the page coordinates. This patch fixes it by using page coordinates instead of relative ones. TEST=Edit a photo, crop, drop the area very fast over the right arrow. BUG=244046 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=202526

Patch Set 1 #

Patch Set 2 : Updated a comment. #

Created: 7 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -6 lines)			Patch
	M	chrome/browser/resources/file_manager/js/image_editor/image_editor.js	View	1	2 chunks	+5 lines, -6 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mtomasz@chromium.org/16080002/11001

7 years, 6 months ago (2013-05-28 06:03:17 UTC) #3

commit-bot: I haz the power

Retried try job too often on linux_chromeos for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chromeos&number=118885

7 years, 6 months ago (2013-05-28 08:00:42 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mtomasz@chromium.org/16080002/11001

7 years, 6 months ago (2013-05-28 09:17:09 UTC) #5

Message was sent while issue was closed.

Change committed as 202526

Expand Messages | Collapse Messages