Issue 16077014: Reenable the tcmalloc SecurityTests in base_unittests on Windows

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 16077014: Reenable the tcmalloc SecurityTests in base_unittests on Windows (Closed)

Created:
7 years, 6 months ago by Will Harris

Modified:
7 years, 6 months ago

Reviewers:
jln (very slow on Chromium)

CC:
chromium-reviews, erikwright+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

Reenable the tcmalloc SecurityTests in base_unittests on Windows These tests now function correctly because base_unittests now is built with allocator_shims - see http://crrev.com/15674003/ BUG=242304 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=205350

Patch Set 1 #

Total comments: 1

Patch Set 2 : fix nit #

Created: 7 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -2 lines)			Patch
	M	base/security_unittest.cc	View	1	2 chunks	+7 lines, -2 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Will Harris

SecurityTests should now pass on Win32 and Win64 when tcmalloc is enabled (i.e. a static ...

7 years, 6 months ago (2013-06-10 11:39:40 UTC) #1

jln (very slow on Chromium)

Excellent, thanks Will! lgtm https://codereview.chromium.org/16077014/diff/1/base/security_unittest.cc File base/security_unittest.cc (right): https://codereview.chromium.org/16077014/diff/1/base/security_unittest.cc#newcode71 base/security_unittest.cc:71: if (allocator && strcmp(allocator, "tcmalloc") ...

7 years, 6 months ago (2013-06-10 16:59:15 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wfh@chromium.org/16077014/6001

7 years, 6 months ago (2013-06-10 17:43:40 UTC) #3

Message was sent while issue was closed.

Change committed as 205350

Expand Messages | Collapse Messages