Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Issue 16077003: Fixed leak in StorageSchemaManifestHandlerTest. (Closed)

Created:
7 years, 7 months ago by Joao da Silva
Modified:
7 years, 6 months ago
CC:
chromium-reviews, Aaron Boodman, chromium-apps-reviews_chromium.org
Visibility:
Public.

Description

Fixed leak in StorageSchemaManifestHandlerTest. This test uses the global ManifestHandlerRegistry, and its result depend on the order of execution of other tests. If any test before created a ManagedValueStoreCache then the ManifestHandlerRegistry has a StorageSchemaManifestHandler, which will try to validate the bad extension manifests, and will make this test fail. This temporary fix always registers a StorageSchemaManifestHandler, and the test doesn't assume that the extension is always created anymore. The long term fix is to make ScopedTestingManifestHandlerRegistry public so that tests like this can have a scoped ManifestHandlerRegistry. TBR=kalman@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=202461

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -11 lines) Patch
M chrome/browser/extensions/api/storage/storage_schema_manifest_handler_unittest.cc View 5 chunks +12 lines, -11 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Joao da Silva
Benjamin, I found this little issue with the global ManifestHandlerRegistry. WDYT of making ScopedTestingManifestHandlerRegistry public ...
7 years, 7 months ago (2013-05-27 17:50:06 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/joaodasilva@chromium.org/16077003/1
7 years, 7 months ago (2013-05-27 17:50:16 UTC) #2
commit-bot: I haz the power
Change committed as 202461
7 years, 7 months ago (2013-05-27 19:57:27 UTC) #3
not at google - send to devlin
7 years, 6 months ago (2013-05-28 14:30:21 UTC) #4
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698