Issue 16077002: Move popup menu code from core/platform to WebKit/chromium/src.

Issue 16077002: Move popup menu code from core/platform to WebKit/chromium/src. (Closed)

Created:
7 years, 7 months ago by tkent

Modified:
7 years, 7 months ago

Reviewers:
Hajime Morrita

CC:
blink-reviews, jeez, eae+blinkwatch

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Move popup menu code from core/platform to WebKit/chromium/src. These code depends on non-platform core code. It's a layering violation. We move them to WebKit/chromium/src like other implementations of platform interfaces. BUG=242763 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=151176

Patch Set 1 : #

Created: 7 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+22 lines, -2054 lines)			Patch
M	Source/WebKit/chromium/WebKit.gyp	View	1 chunk	+6 lines, -0 lines	0 comments	Download
M	Source/WebKit/chromium/src/ChromeClientImpl.cpp	View	2 chunks	+2 lines, -2 lines	0 comments	Download
A +	Source/WebKit/chromium/src/PopupContainer.h	View	1 chunk	+1 line, -1 line	0 comments	Download
A +	Source/WebKit/chromium/src/PopupContainer.cpp	View	2 chunks	+2 lines, -2 lines	0 comments	Download
A +	Source/WebKit/chromium/src/PopupListBox.h	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	Source/WebKit/chromium/src/PopupListBox.cpp	View	2 chunks	+3 lines, -3 lines	0 comments	Download
A +	Source/WebKit/chromium/src/PopupMenuChromium.h	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	Source/WebKit/chromium/src/PopupMenuChromium.cpp	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	Source/WebKit/chromium/src/WebPopupMenuImpl.cpp	View	2 chunks	+3 lines, -3 lines	0 comments	Download
M	Source/WebKit/chromium/src/WebViewImpl.cpp	View	2 chunks	+1 line, -1 line	0 comments	Download
M	Source/WebKit/chromium/tests/PopupContainerTest.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/WebKit/chromium/tests/PopupMenuTest.cpp	View	2 chunks	+3 lines, -3 lines	0 comments	Download
M	Source/core/core.gypi	View	1 chunk	+0 lines, -6 lines	0 comments	Download
D	Source/core/platform/chromium/PopupContainer.h	View	1 chunk	+0 lines, -161 lines	0 comments	Download
D	Source/core/platform/chromium/PopupContainer.cpp	View	1 chunk	+0 lines, -461 lines	0 comments	Download
D	Source/core/platform/chromium/PopupListBox.h	View	1 chunk	+0 lines, -303 lines	0 comments	Download
D	Source/core/platform/chromium/PopupListBox.cpp	View	1 chunk	+0 lines, -935 lines	0 comments	Download
D	Source/core/platform/chromium/PopupMenuChromium.h	View	1 chunk	+0 lines, -74 lines	0 comments	Download
D	Source/core/platform/chromium/PopupMenuChromium.cpp	View	1 chunk	+0 lines, -98 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tkent@chromium.org/16077002/3001

7 years, 7 months ago (2013-05-27 05:57:29 UTC) #3

Message was sent while issue was closed.

Change committed as 151176

Expand Messages | Collapse Messages