Issue 16075002: mac: Make notification text colors match views.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 16075002: mac: Make notification text colors match views. (Closed)

Created:
7 years, 7 months ago by Nico

Modified:
7 years, 6 months ago

Reviewers:
Robert Sesek, dharcourt

CC:
chromium-reviews, sail+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

mac: Make notification text colors match views. Notification titles and button text is drawn in kRegularTextColor, notifcation message text is drawn in kDimTextColor. Move kDimTextColor to message_center_style so that it can be shared. BUG=240877 NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=202628

Patch Set 1 #

Created: 7 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+13 lines, -8 lines)			Patch
M	ui/message_center/cocoa/notification_controller.mm	View	4 chunks	+8 lines, -5 lines	0 comments	Download
M	ui/message_center/message_center_style.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	ui/message_center/message_center_style.cc	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	ui/message_center/views/notification_view.cc	View	3 chunks	+3 lines, -3 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thakis@chromium.org/16075002/1

7 years, 6 months ago (2013-05-28 19:39:11 UTC) #4

Message was sent while issue was closed.

Change committed as 202628

Expand Messages | Collapse Messages