Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(144)

Issue 16074003: [content shell] don't open new windows after printing the test results (Closed)

Created:
7 years, 6 months ago by jochen (gone - plz use gerrit)
Modified:
7 years, 6 months ago
Reviewers:
marja
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, jochen+watch_chromium.org
Visibility:
Public.

Description

[content shell] don't open new windows after printing the test results Otherwise, if there's e.g. still a download in flight, we might open a new window after closing all windows but before starting the next test BUG=111316 R=marja@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=202552

Patch Set 1 #

Total comments: 1

Patch Set 2 : enum #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -8 lines) Patch
M content/shell/webkit_test_controller.h View 1 2 chunks +8 lines, -3 lines 0 comments Download
M content/shell/webkit_test_controller.cc View 1 7 chunks +10 lines, -5 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
jochen (gone - plz use gerrit)
7 years, 6 months ago (2013-05-28 11:10:00 UTC) #1
marja
lgtm but.. https://codereview.chromium.org/16074003/diff/1/content/shell/webkit_test_controller.h File content/shell/webkit_test_controller.h (right): https://codereview.chromium.org/16074003/diff/1/content/shell/webkit_test_controller.h#newcode165 content/shell/webkit_test_controller.h:165: bool is_cleaning_up_; Would it make sense to ...
7 years, 6 months ago (2013-05-28 11:16:35 UTC) #2
jochen (gone - plz use gerrit)
ptal
7 years, 6 months ago (2013-05-28 11:30:47 UTC) #3
marja
cool, lgtm
7 years, 6 months ago (2013-05-28 11:35:18 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jochen@chromium.org/16074003/4001
7 years, 6 months ago (2013-05-28 11:49:12 UTC) #5
commit-bot: I haz the power
7 years, 6 months ago (2013-05-28 13:54:47 UTC) #6
Message was sent while issue was closed.
Change committed as 202552

Powered by Google App Engine
This is Rietveld 408576698