Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(60)

Issue 16073003: [Mac][MC] Allow right click to open the message center tray. (Closed)

Created:
7 years, 6 months ago by Robert Sesek
Modified:
7 years, 6 months ago
Reviewers:
Nico, dewittj
CC:
chromium-reviews, sail+watch_chromium.org
Visibility:
Public.

Description

[Mac][MC] Allow right click to open the message center tray. BUG=243937 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=202627

Patch Set 1 #

Total comments: 2

Patch Set 2 : otherMouseDown #

Patch Set 3 : Remove DCHECKs #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -2 lines) Patch
M ui/message_center/cocoa/status_item_view.mm View 1 2 2 chunks +16 lines, -2 lines 0 comments Download
M ui/message_center/cocoa/status_item_view_unittest.mm View 1 1 chunk +11 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
Robert Sesek
7 years, 6 months ago (2013-05-28 15:27:55 UTC) #1
Nico
lgtm https://codereview.chromium.org/16073003/diff/1/ui/message_center/cocoa/status_item_view.mm File ui/message_center/cocoa/status_item_view.mm (right): https://codereview.chromium.org/16073003/diff/1/ui/message_center/cocoa/status_item_view.mm#newcode78 ui/message_center/cocoa/status_item_view.mm:78: } otherMouseDown/Up: too?
7 years, 6 months ago (2013-05-28 16:05:07 UTC) #2
Robert Sesek
https://codereview.chromium.org/16073003/diff/1/ui/message_center/cocoa/status_item_view.mm File ui/message_center/cocoa/status_item_view.mm (right): https://codereview.chromium.org/16073003/diff/1/ui/message_center/cocoa/status_item_view.mm#newcode78 ui/message_center/cocoa/status_item_view.mm:78: } On 2013/05/28 16:05:08, Nico wrote: > otherMouseDown/Up: too? ...
7 years, 6 months ago (2013-05-28 16:16:23 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rsesek@chromium.org/16073003/6001
7 years, 6 months ago (2013-05-28 16:16:46 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rsesek@chromium.org/16073003/6001
7 years, 6 months ago (2013-05-28 16:19:19 UTC) #5
dewittj
I think this code can trigger a DCHECK if the user clicks with left mouse, ...
7 years, 6 months ago (2013-05-28 16:23:07 UTC) #6
Robert Sesek
On 2013/05/28 16:23:07, dewittj wrote: > I think this code can trigger a DCHECK if ...
7 years, 6 months ago (2013-05-28 16:28:46 UTC) #7
dewittj
lgtm
7 years, 6 months ago (2013-05-28 16:37:45 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rsesek@chromium.org/16073003/16002
7 years, 6 months ago (2013-05-28 16:38:12 UTC) #9
commit-bot: I haz the power
7 years, 6 months ago (2013-05-28 19:59:42 UTC) #10
Message was sent while issue was closed.
Change committed as 202627

Powered by Google App Engine
This is Rietveld 408576698