Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(484)

Issue 16069006: Include BrowserInstantController in Android builds. (Closed)

Created:
7 years, 6 months ago by kmadhusu
Modified:
7 years, 6 months ago
Reviewers:
rpetterson, sky
CC:
chromium-reviews
Visibility:
Public.

Description

Include BrowserInstantController in Android builds. BUG=none TEST=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=202718

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M chrome/chrome_browser_ui.gypi View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
kmadhusu
When I include browser_instant_controller.cc in android builds, I am not seeing any failure. It's because ...
7 years, 6 months ago (2013-05-28 20:28:30 UTC) #1
rpetterson
LGTM Thanks for catching this!
7 years, 6 months ago (2013-05-28 20:30:25 UTC) #2
kmadhusu
sky@: Please do the OWNER's check for the *.gypi file change. Thanks.
7 years, 6 months ago (2013-05-28 21:16:24 UTC) #3
sky
You do not need me for *gypi files, anyone can review them. On Tue, May ...
7 years, 6 months ago (2013-05-28 21:29:58 UTC) #4
kmadhusu
On 2013/05/28 21:29:58, sky wrote: > You do not need me for *gypi files, anyone ...
7 years, 6 months ago (2013-05-28 21:31:40 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kmadhusu@chromium.org/16069006/1
7 years, 6 months ago (2013-05-28 21:32:06 UTC) #6
commit-bot: I haz the power
7 years, 6 months ago (2013-05-29 00:41:14 UTC) #7
Message was sent while issue was closed.
Change committed as 202718

Powered by Google App Engine
This is Rietveld 408576698