Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(181)

Issue 16067003: [Quota] Refine usage handling in ClientUsageTracker. (Closed)

Created:
7 years, 7 months ago by tzik
Modified:
7 years, 7 months ago
Reviewers:
kinuko
CC:
chromium-reviews, darin-cc_chromium.org
Visibility:
Public.

Description

[Quota] Refine usage handling in ClientUsageTracker. This CL split global_usage_ into global_limited_usage_ and global_unlimited_usage_ to prepare for adding GetGlobalLimitedUsage. BUG=220029 TEST=no functional change, should not break existing tests Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=202454

Patch Set 1 #

Patch Set 2 : simplify usage update #

Total comments: 3

Patch Set 3 : ref to ptr #

Patch Set 4 : buildfix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+86 lines, -32 lines) Patch
M webkit/quota/usage_tracker.h View 3 chunks +4 lines, -3 lines 0 comments Download
M webkit/quota/usage_tracker.cc View 1 2 3 11 chunks +82 lines, -29 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
tzik
PTL
7 years, 7 months ago (2013-05-27 11:37:36 UTC) #1
kinuko
lgtm https://codereview.chromium.org/16067003/diff/2001/webkit/quota/usage_tracker.cc File webkit/quota/usage_tracker.cc (right): https://codereview.chromium.org/16067003/diff/2001/webkit/quota/usage_tracker.cc#newcode475 webkit/quota/usage_tracker.cc:475: usage = new_usage; Feels slightly uneasy to use ...
7 years, 7 months ago (2013-05-27 11:54:24 UTC) #2
tzik
https://codereview.chromium.org/16067003/diff/2001/webkit/quota/usage_tracker.cc File webkit/quota/usage_tracker.cc (right): https://codereview.chromium.org/16067003/diff/2001/webkit/quota/usage_tracker.cc#newcode475 webkit/quota/usage_tracker.cc:475: usage = new_usage; On 2013/05/27 11:54:24, kinuko wrote: > ...
7 years, 7 months ago (2013-05-27 15:13:21 UTC) #3
kinuko
https://codereview.chromium.org/16067003/diff/2001/webkit/quota/usage_tracker.cc File webkit/quota/usage_tracker.cc (right): https://codereview.chromium.org/16067003/diff/2001/webkit/quota/usage_tracker.cc#newcode475 webkit/quota/usage_tracker.cc:475: usage = new_usage; On 2013/05/27 15:13:21, tzik wrote: > ...
7 years, 7 months ago (2013-05-27 15:27:32 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tzik@chromium.org/16067003/8003
7 years, 7 months ago (2013-05-27 17:27:18 UTC) #5
commit-bot: I haz the power
7 years, 7 months ago (2013-05-27 18:43:29 UTC) #6
Message was sent while issue was closed.
Change committed as 202454

Powered by Google App Engine
This is Rietveld 408576698