Unescape resource id and search query contained in feed url in FakeDriveService

Unescape resource id and search query contained in feed url in FakeDriveService


BUG=243616
TEST=pass all existing tests

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=203963

[nhiroki, 2013-06-04 06:15:26]

Hi kinaba-san, can you review this? Thanks!

[kinaba, 2013-06-04 06:46:52]

Thanks for the good catch!

https://codereview.chromium.org/16063009/diff/1/chrome/browser/google_apis/fa...
File chrome/browser/google_apis/fake_drive_service.cc (right):

https://codereview.chromium.org/16063009/diff/1/chrome/browser/google_apis/fa...
chrome/browser/google_apis/fake_drive_service.cc:349: search_query =
parameters[i].second;
Do we also need unescaping here as well?
If so, could you please add it?

[nhiroki, 2013-06-04 07:05:52]

Thank you for reviewing. Updated.

https://codereview.chromium.org/16063009/diff/1/chrome/browser/google_apis/fa...
File chrome/browser/google_apis/fake_drive_service.cc (right):

https://codereview.chromium.org/16063009/diff/1/chrome/browser/google_apis/fa...
chrome/browser/google_apis/fake_drive_service.cc:349: search_query =
parameters[i].second;
On 2013/06/04 06:46:52, kinaba wrote:
> Do we also need unescaping here as well?
> If so, could you please add it?

That's right. Done.

[kinaba, 2013-06-04 07:06:31]

Thank you! lgtm

[commit-bot: I haz the power, 2013-06-04 07:07:58]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/nhiroki@chromium.org/16063009/7002

[commit-bot: I haz the power, 2013-06-04 14:33:54]

Change committed as 203963