Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(199)

Issue 16058007: Increase expectation on output of gclient for help and unknown command. (Closed)

Created:
7 years, 6 months ago by tyoshino (SeeGerritForStatus)
Modified:
7 years, 6 months ago
Reviewers:
iannucci, M-A Ruel
CC:
chromium-reviews, Dirk Pranke, cmp-cc_chromium.org, M-A Ruel, iannucci+depot_tools_chromium.org
Visibility:
Public.

Description

Increase expectation on output of gclient for help and unknown command. Also adds msg to assertions to print current size of data written to stdout. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=202863

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M tests/gclient_smoketest.py View 1 chunk +4 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
tyoshino (SeeGerritForStatus)
7 years, 6 months ago (2013-05-29 06:09:03 UTC) #1
tyoshino (SeeGerritForStatus)
Currently, the size of output for help command is 2064 byte. Looks like we need ...
7 years, 6 months ago (2013-05-29 06:11:51 UTC) #2
M-A Ruel
Thanks for fixing. lgtm
7 years, 6 months ago (2013-05-29 14:10:34 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tyoshino@chromium.org/16058007/1
7 years, 6 months ago (2013-05-29 14:10:47 UTC) #4
commit-bot: I haz the power
7 years, 6 months ago (2013-05-29 14:12:24 UTC) #5
Message was sent while issue was closed.
Change committed as 202863

Powered by Google App Engine
This is Rietveld 408576698