Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1190)

Issue 16057022: cros: Update charging not reliable battery status (Closed)

Created:
7 years, 6 months ago by James Cook
Modified:
7 years, 6 months ago
Reviewers:
Daniel Erat
CC:
chromium-reviews, stevenjb+watch_chromium.org, sadrul, oshima+watch_chromium.org, derat+watch_chromium.org, ben+watch_chromium.org
Visibility:
Public.

Description

cros: Update charging not reliable battery status Don't display the "charging not reliable" battery status in the non-charging-non-discharging state, as that can happen normally in some circumstances. Also, update the string to be more human-friendly. BUG=246336 TEST=manual, see bug Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=203952 R=derat@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=204595

Patch Set 1 #

Patch Set 2 : comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -7 lines) Patch
M ash/ash_strings.grd View 2 chunks +2 lines, -2 lines 0 comments Download
M ash/system/chromeos/power/tray_power.cc View 1 1 chunk +6 lines, -5 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
James Cook
derat, PTAL
7 years, 6 months ago (2013-06-03 22:59:25 UTC) #1
Daniel Erat
lgtm
7 years, 6 months ago (2013-06-03 23:03:36 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamescook@chromium.org/16057022/2001
7 years, 6 months ago (2013-06-03 23:07:08 UTC) #3
commit-bot: I haz the power
Step "update" is always a major failure. Look at the try server FAQ for more ...
7 years, 6 months ago (2013-06-03 23:20:14 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamescook@chromium.org/16057022/2001
7 years, 6 months ago (2013-06-04 12:12:22 UTC) #5
commit-bot: I haz the power
Change committed as 203952
7 years, 6 months ago (2013-06-04 13:04:19 UTC) #6
James Cook
On 2013/06/04 13:04:19, I haz the power (commit-bot) wrote: > Change committed as 203952 Reverted ...
7 years, 6 months ago (2013-06-04 17:08:02 UTC) #7
James Cook
> Reverted because I need to hard-code the string in C++ for backport to M28. ...
7 years, 6 months ago (2013-06-06 21:08:46 UTC) #8
James Cook
7 years, 6 months ago (2013-06-06 21:11:33 UTC) #9
Message was sent while issue was closed.
Committed patchset #2 manually as r204595 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698