Pass --no-renames to git diff

Pass --no-renames to git diff

If ~/.gitconfig contains:
	[diff]
		renames = "true"
then git diff --name-status will produce output that confuses the parsing
in svm.GIT.CaptureStatus and git diff will produce output that confuses the
patch command on trybots.  Passing --no-renames explicitly counteracts this.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=203778

[M-A Ruel, 2013-06-03 21:00:47]

I'm confused, this is for "git try" and not "git cl try", right?

[Roland McGrath, 2013-06-03 21:01:35]

On 2013/06/03 21:00:47, Marc-Antoine Ruel wrote:
> I'm confused, this is for "git try" and not "git cl try", right?

One spot broke 'git cl upload' and another spot broke 'git try'.

[M-A Ruel, 2013-06-03 21:05:42]

On 2013/06/03 21:01:35, Roland McGrath wrote:
> On 2013/06/03 21:00:47, Marc-Antoine Ruel wrote:
> > I'm confused, this is for "git try" and not "git cl try", right?
> 
> One spot broke 'git cl upload' and another spot broke 'git try'.

I see. Do you know in which git version was --no-renames added? I just don't
want to break older clients.

[Roland McGrath, 2013-06-03 21:15:50]

On 2013/06/03 21:05:42, Marc-Antoine Ruel wrote:
> On 2013/06/03 21:01:35, Roland McGrath wrote:
> > On 2013/06/03 21:00:47, Marc-Antoine Ruel wrote:
> > > I'm confused, this is for "git try" and not "git cl try", right?
> > 
> > One spot broke 'git cl upload' and another spot broke 'git try'.
> 
> I see. Do you know in which git version was --no-renames added? I just don't
> want to break older clients.

I've been using git since its inception and I'm not aware of a time when
commands like 'git diff' existed but didn't grok --no-renames.
It seems especially unlikely that there was a version that new -C but not
--no-renames.
But one would have to check git sources to be sure.

[M-A Ruel, 2013-06-03 21:22:12]

On 2013/06/03 21:15:50, Roland McGrath wrote:
> On 2013/06/03 21:05:42, Marc-Antoine Ruel wrote:
> > I see. Do you know in which git version was --no-renames added? I just don't
> > want to break older clients.
> 
> I've been using git since its inception and I'm not aware of a time when
> commands like 'git diff' existed but didn't grok --no-renames.
> It seems especially unlikely that there was a version that new -C but not
> --no-renames.
> But one would have to check git sources to be sure.

Ok, lgtm.

At worst, someone will be broken and will hopefully complain.

[commit-bot: I haz the power, 2013-06-03 21:34:18]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mcgrathr@chromium.org/16057018/1

[commit-bot: I haz the power, 2013-06-03 21:36:19]

Change committed as 203778