Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(125)

Issue 16056002: Cleanup Various bits of Windows StorageMonitor classes. (Closed)

Created:
7 years, 7 months ago by Lei Zhang
Modified:
7 years, 6 months ago
Reviewers:
Greg Billock
CC:
chromium-reviews
Visibility:
Public.

Description

Cleanup Various bits of Windows StorageMonitor classes. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=203114

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+108 lines, -116 lines) Patch
M chrome/browser/storage_monitor/storage_monitor_win.h View 1 2 2 chunks +3 lines, -4 lines 0 comments Download
M chrome/browser/storage_monitor/storage_monitor_win.cc View 1 2 4 chunks +5 lines, -10 lines 0 comments Download
M chrome/browser/storage_monitor/storage_monitor_win_unittest.cc View 1 2 7 chunks +14 lines, -14 lines 0 comments Download
M chrome/browser/storage_monitor/test_volume_mount_watcher_win.h View 1 2 3 chunks +5 lines, -6 lines 0 comments Download
M chrome/browser/storage_monitor/test_volume_mount_watcher_win.cc View 1 2 4 chunks +8 lines, -7 lines 0 comments Download
M chrome/browser/storage_monitor/volume_mount_watcher_win.h View 1 2 4 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/storage_monitor/volume_mount_watcher_win.cc View 1 2 22 chunks +68 lines, -70 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Lei Zhang
7 years, 6 months ago (2013-05-29 02:43:01 UTC) #1
Greg Billock
lgtm
7 years, 6 months ago (2013-05-30 00:30:38 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thestig@chromium.org/16056002/8001
7 years, 6 months ago (2013-05-30 01:51:19 UTC) #3
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 6 months ago (2013-05-30 03:36:55 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thestig@chromium.org/16056002/31001
7 years, 6 months ago (2013-05-30 03:44:14 UTC) #5
commit-bot: I haz the power
7 years, 6 months ago (2013-05-30 08:08:25 UTC) #6
Message was sent while issue was closed.
Change committed as 203114

Powered by Google App Engine
This is Rietveld 408576698