server/prpc/method.go - Issue 1605363002: common/prpc, tools/cmd/cproto: prpc client

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: server/prpc/method.go

Issue 1605363002: common/prpc, tools/cmd/cproto: prpc client (Closed) Base URL: https://chromium.googlesource.com/external/github.com/luci/luci-go@master

Patch Set: use text template for ast generation Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: server/prpc/method.go

diff --git a/server/prpc/method.go b/server/prpc/method.go

index aa0b5c2f61779991a2fc375ca356a5b8a9974e91..076262c5aef402929e4f2d8354f97464dcab27ef 100644

--- a/server/prpc/method.go

+++ b/server/prpc/method.go

@@ -57,7 +57,7 @@ func (m *method) handle(c context.Context, w http.ResponseWriter, r *http.Reques

res, rawErr := m.desc.Handler(m.service.impl, c, func(msg interface{}) error {

if msg == nil {

- panicf("cannot decode to nil")

+ panicf("msg is nil")

}

// Do not collapse it to one line. There is implicit err type conversion.

if err := readMessage(r, msg.(proto.Message)); err != nil {

« server/prpc/encoding.go ('K') | « server/prpc/helloworld_test.pb_test.go ('k') | tools/cmd/cproto/testdata/helloworld/test.pb.golden » ('j') | no next file with comments »