Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Issue 16051006: ui/gfx: Use base::string16 now that string16 was moved into base namespace. (Closed)

Created:
7 years, 6 months ago by tfarina
Modified:
7 years, 6 months ago
CC:
chromium-reviews, derat+watch_chromium.org, sail+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

ui/gfx: Use base::string16 now that string16 was moved into base namespace. base/string16.h was moved into base namespace in r191198 by Brett. BUG=None TBR=ben@chromium.org NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=205096

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+113 lines, -108 lines) Patch
M ui/gfx/canvas.h View 7 chunks +8 lines, -8 lines 0 comments Download
M ui/gfx/canvas.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M ui/gfx/canvas_android.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M ui/gfx/canvas_mac.mm View 3 chunks +4 lines, -4 lines 0 comments Download
M ui/gfx/canvas_skia.cc View 14 chunks +18 lines, -17 lines 0 comments Download
M ui/gfx/canvas_unittest.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M ui/gfx/font.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/gfx/font.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/gfx/font_fallback_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/gfx/font_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ui/gfx/pango_util.h View 3 chunks +3 lines, -3 lines 0 comments Download
M ui/gfx/pango_util.cc View 5 chunks +5 lines, -5 lines 0 comments Download
M ui/gfx/platform_font.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/gfx/platform_font_ios.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/gfx/platform_font_ios.mm View 1 chunk +1 line, -1 line 0 comments Download
M ui/gfx/platform_font_mac.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/gfx/platform_font_mac.mm View 1 chunk +1 line, -1 line 0 comments Download
M ui/gfx/platform_font_pango.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/gfx/platform_font_pango.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/gfx/platform_font_win.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/gfx/platform_font_win.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M ui/gfx/render_text.h View 4 chunks +5 lines, -5 lines 0 comments Download
M ui/gfx/render_text.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M ui/gfx/render_text_unittest.cc View 11 chunks +31 lines, -28 lines 0 comments Download
M ui/gfx/text_utils.h View 1 chunk +4 lines, -4 lines 0 comments Download
M ui/gfx/text_utils.cc View 1 chunk +5 lines, -5 lines 0 comments Download
M ui/gfx/text_utils_unittest.cc View 1 chunk +4 lines, -4 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
tfarina
TBRing...
7 years, 6 months ago (2013-06-08 23:02:32 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/16051006/1
7 years, 6 months ago (2013-06-08 23:02:54 UTC) #2
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) sync_integration_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=160113
7 years, 6 months ago (2013-06-09 03:01:28 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/16051006/1
7 years, 6 months ago (2013-06-09 03:32:22 UTC) #4
commit-bot: I haz the power
Change committed as 205096
7 years, 6 months ago (2013-06-09 03:32:37 UTC) #5
Ben Goodger (Google)
7 years, 6 months ago (2013-06-11 16:07:57 UTC) #6
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698