Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(253)

Side by Side Diff: test/mjsunit/object-freeze.js

Issue 16051002: Fix Object.freeze for objects with mixed accessors and data properties (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« src/objects.cc ('K') | « src/objects.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2010 the V8 project authors. All rights reserved. 1 // Copyright 2010 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 278 matching lines...) Expand 10 before | Expand all | Expand 10 after
289 enumerable: true 289 enumerable: true
290 }); 290 });
291 assertTrue(%HasFastProperties(obj)); 291 assertTrue(%HasFastProperties(obj));
292 Object.freeze(obj); 292 Object.freeze(obj);
293 assertTrue(Object.isFrozen(obj)); 293 assertTrue(Object.isFrozen(obj));
294 assertTrue(%HasFastProperties(obj)); 294 assertTrue(%HasFastProperties(obj));
295 assertEquals(42, obj.accessor); 295 assertEquals(42, obj.accessor);
296 accessorDidRun = false; 296 accessorDidRun = false;
297 obj.accessor = 'ignored value'; 297 obj.accessor = 'ignored value';
298 assertTrue(accessorDidRun); 298 assertTrue(accessorDidRun);
299
300 // Test for regression in mixed accessor/data property objects.
301 // The strict function is one such object.
302 assertTrue(Object.isFrozen(Object.freeze(function(){"use strict";})));
303
304 // Also test a simpler case
305 obj = {};
306 Object.defineProperty(obj, 'accessor', {
307 get: function() { return 42 },
308 set: function() { accessorDidRun = true },
309 configurable: true,
310 enumerable: true
311 });
312 obj.data = 'foo';
313 assertTrue(%HasFastProperties(obj));
314 Object.freeze(obj);
315 assertTrue(%HasFastProperties(obj));
316 assertTrue(Object.isFrozen(obj));
OLDNEW
« src/objects.cc ('K') | « src/objects.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698