Shows the display info as a popup when a new display is connected.

Shows the display info as a popup when a new display is connected.

This CL also removes some event triggering. They update the default
view when visible, but this is not necessary because the tray bubble
itself will be closed when display configuration has changed.

Also this CL cleans up messages of the tray item contents.

BUG=187516, 171469
R=oshima@chromium.org, stevenjb@chromium.org
TEST=manually

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=203789

[stevenjb, 2013-05-31 20:05:46]

lgtm

[Jun Mukai, 2013-05-31 21:27:11]

talked with oshima offline and noticed my patchset 1 was slightly wrong.
I fixed that problem and also cleaned up some code by using the new enum.

PTAL

[stevenjb, 2013-05-31 21:43:11]

lgtm w/ nits

https://codereview.chromium.org/16046007/diff/5001/ash/system/chromeos/tray_d...
File ash/system/chromeos/tray_display.cc (right):

https://codereview.chromium.org/16046007/diff/5001/ash/system/chromeos/tray_d...
ash/system/chromeos/tray_display.cc:44: }
nit:  // namespace

https://codereview.chromium.org/16046007/diff/5001/ash/system/chromeos/tray_d...
ash/system/chromeos/tray_display.cc:97: IDS_ASH_STATUS_TRAY_DISPLAY_DOCKED,
GetExternalDisplayName()));
nit: break; (for consistency)

[Jun Mukai, 2013-05-31 21:50:17]

https://codereview.chromium.org/16046007/diff/5001/ash/system/chromeos/tray_d...
File ash/system/chromeos/tray_display.cc (right):

https://codereview.chromium.org/16046007/diff/5001/ash/system/chromeos/tray_d...
ash/system/chromeos/tray_display.cc:44: }
On 2013/05/31 21:43:11, stevenjb (chromium) wrote:
> nit:  // namespace

Done.

https://codereview.chromium.org/16046007/diff/5001/ash/system/chromeos/tray_d...
ash/system/chromeos/tray_display.cc:97: IDS_ASH_STATUS_TRAY_DISPLAY_DOCKED,
GetExternalDisplayName()));
On 2013/05/31 21:43:11, stevenjb (chromium) wrote:
> nit: break; (for consistency)

Done.

[oshima, 2013-05-31 21:59:16]

lgtm

[commit-bot: I haz the power, 2013-05-31 22:39:28]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mukai@chromium.org/16046007/8006

[commit-bot: I haz the power, 2013-05-31 23:53:13]

Retried try job too often on linux_chromeos for step(s) ash_unittests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chro...

[Jun Mukai, 2013-06-03 19:59:34]

PTAL

noticed that I was using PopupDetailedView but here I should use
ShowNotificationView instead.

[stevenjb, 2013-06-03 21:31:48]

Cool, this looks better. LGTM.

[commit-bot: I haz the power, 2013-06-03 21:40:00]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mukai@chromium.org/16046007/25001

[commit-bot: I haz the power, 2013-06-03 23:37:58]

Change committed as 203789