Issue 16045004: Fixing the webrtc local audio renderer timer between Stop() and Start().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 16045004: Fixing the webrtc local audio renderer timer between Stop() and Start(). (Closed)

Created:
7 years, 7 months ago by no longer working on chromium

Modified:
7 years, 7 months ago

Reviewers:
henrika (OOO until Aug 14)

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, feature-media-reviews_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Fixing the webrtc local audio renderer timer between Stop() and Start(). After calling Stop(), the timer should just stop. BUG=244192 TEST= https://webrtc.googlecode.com/svn/trunk/samples/js/demos/html/local-audio-rendering.html Calling Start/Stop, the timer used to start/stop counting. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=202419

Created: 7 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -4 lines)			Patch
	M	content/renderer/media/webrtc_local_audio_renderer.cc	View		2 chunks	+4 lines, -4 lines	0 comments	Download

Total messages: 4 (0 generated)

henrika (OOO until Aug 14)

LGTM. Let me know when landed and I can try locally as well.

7 years, 7 months ago (2013-05-27 10:34:04 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/xians@chromium.org/16045004/1

7 years, 7 months ago (2013-05-27 10:36:06 UTC) #3

Message was sent while issue was closed.

Change committed as 202419