Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(318)

Issue 16043002: Create content switches for frame scheduling and input manager (Closed)

Created:
7 years, 7 months ago by jdduke (slow)
Modified:
7 years, 6 months ago
CC:
chromium-reviews, nkostylev+watch_chromium.org, jam, apatrick_chromium, joi+watch-content_chromium.org, darin-cc_chromium.org, oshima+watch_chromium.org, stevenjb+watch_chromium.org, android-webview-reviews_chromium.org, davemoore+watch_chromium.org, brianderson
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Create content switches for frame scheduling and input manager The new scheduling approach consists of both changes to how frames are scheduled and when input events are processed. This patch renames a switch for the former and adds a switch for the latter, to be used for ongoing development. BUG=240945 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=202993

Patch Set 1 #

Patch Set 2 : Fix typo #

Patch Set 3 : Rename setting corresponding to flag, remove unused switch #

Patch Set 4 : Remove RightAligned switch #

Patch Set 5 : Rebase #

Patch Set 6 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -28 lines) Patch
M android_webview/lib/main/aw_main_delegate.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M cc/base/switches.h View 1 2 3 4 1 chunk +0 lines, -1 line 0 comments Download
M cc/base/switches.cc View 1 2 3 4 1 chunk +0 lines, -3 lines 0 comments Download
M cc/trees/layer_tree_host_unittest.cc View 1 2 3 chunks +3 lines, -3 lines 0 comments Download
M cc/trees/layer_tree_settings.h View 1 2 3 4 1 chunk +1 line, -2 lines 0 comments Download
M cc/trees/layer_tree_settings.cc View 1 2 3 4 1 chunk +1 line, -2 lines 0 comments Download
M cc/trees/thread_proxy.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M cc/trees/thread_proxy.cc View 1 2 3 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/login/chrome_restart_request.cc View 1 2 3 4 3 chunks +2 lines, -2 lines 0 comments Download
M content/browser/renderer_host/render_process_host_impl.cc View 1 2 3 4 3 chunks +2 lines, -2 lines 0 comments Download
M content/public/common/content_switches.h View 1 2 3 4 1 chunk +2 lines, -1 line 0 comments Download
M content/public/common/content_switches.cc View 1 2 3 4 1 chunk +5 lines, -2 lines 0 comments Download
M content/renderer/gpu/render_widget_compositor.cc View 1 2 3 4 2 chunks +2 lines, -4 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
jdduke (slow)
This is a simple switch rename and switch addition. PTAL, thanks! @joth: android_webview @davemoore: chrome/browser/chromeos/ ...
7 years, 7 months ago (2013-05-24 22:29:46 UTC) #1
brianderson
lgtm. Is it worth renaming render_parent_drives_begin_frame_ as part of the same patch?
7 years, 7 months ago (2013-05-24 22:34:01 UTC) #2
Jói
LGTM for //content/public.
7 years, 7 months ago (2013-05-24 22:41:50 UTC) #3
jdduke (slow)
@nduca: Could you take a peak at cc/ ? kEnableRightAlignedScheduling is no more.
7 years, 7 months ago (2013-05-24 22:57:24 UTC) #4
nduca
cc/ lgtm
7 years, 7 months ago (2013-05-24 22:57:53 UTC) #5
joth
aw/ lgtm
7 years, 7 months ago (2013-05-25 00:30:45 UTC) #6
jdduke (slow)
OK, fixing owners. Just need the following for review, thanks! @sky: chrome/ and content/browser? @jamesr: ...
7 years, 7 months ago (2013-05-25 01:07:24 UTC) #7
jamesr
content/renderer lgtm
7 years, 7 months ago (2013-05-25 01:23:49 UTC) #8
sky
LGTM
7 years, 7 months ago (2013-05-27 15:33:41 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jdduke@chromium.org/16043002/15001
7 years, 6 months ago (2013-05-29 15:33:31 UTC) #10
commit-bot: I haz the power
Step "update" is always a major failure. Look at the try server FAQ for more ...
7 years, 6 months ago (2013-05-29 16:05:28 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jdduke@chromium.org/16043002/25001
7 years, 6 months ago (2013-05-29 16:18:21 UTC) #12
commit-bot: I haz the power
7 years, 6 months ago (2013-05-29 22:37:20 UTC) #13
Message was sent while issue was closed.
Change committed as 202993

Powered by Google App Engine
This is Rietveld 408576698