Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(920)

Issue 16035005: Fix crash when quickly dragging a new tab. (Closed)

Created:
7 years, 7 months ago by dcheng
Modified:
7 years, 7 months ago
Reviewers:
Elliot Glaysher, dcheng
CC:
chromium-reviews
Visibility:
Public.

Description

Fix crash when quickly dragging a new tab. The root cause is r185551, which changed the semantics of scoped_ptr::reset(). This code depended on the fact that a get() during a reset() would return the original value of the stored pointer, but after r185551, it returns the value that it is being reset to. This caused the code to stop an animation and the code to end a drag to conflict, since the animation code would sometimes delete a TabGtk that was still being dragged. BUG=228918 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=202184

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/browser/ui/gtk/tabs/tab_strip_gtk.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
dcheng
7 years, 7 months ago (2013-05-24 18:27:40 UTC) #1
Elliot Glaysher
lgtm
7 years, 7 months ago (2013-05-24 18:29:56 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dcheng@chromium.org/16035005/1
7 years, 7 months ago (2013-05-24 18:40:32 UTC) #3
commit-bot: I haz the power
7 years, 7 months ago (2013-05-24 21:49:43 UTC) #4
Message was sent while issue was closed.
Change committed as 202184

Powered by Google App Engine
This is Rietveld 408576698