Use image decoding in pinspect

Small change that eliminates Parse Errors with encoded skps.

Committed: http://code.google.com/p/skia/source/detail?r=9538

[sglez, 2013-06-11 22:10:11]

Hi!
This is a little fix to make pinspect stop emitting errors

[caryclark, 2013-06-12 12:03:11]

https://codereview.chromium.org/16034015/diff/3/tools/pinspect.cpp
File tools/pinspect.cpp (right):

https://codereview.chromium.org/16034015/diff/3/tools/pinspect.cpp#newcode43
tools/pinspect.cpp:43: SkDebugf("Could not create SkPicture");
include the path that failed in the printf, and terminate with a \n

[reed1, 2013-06-12 13:46:23]

Leon, is this the right way to ensure we use "lazy" decoding? For pinspect, we
never actually need the bits, so I want to be sure we're taking advantage of
that.

[scroggo, 2013-06-12 14:05:05]

On 2013/06/12 13:46:23, reed1 wrote:
> Leon, is this the right way to ensure we use "lazy" decoding? For pinspect, we
> never actually need the bits, so I want to be sure we're taking advantage of
> that.

For lazy decoding, you can use a function like lazy_decode_bitmap here:
https://code.google.com/p/skia/source/browse/trunk/tools/PictureRenderingFlag....
If you make pinspect depend on the flags project (in tools), you can extern that
function and use the same one.

[sglez, 2013-06-12 15:37:36]

Now using lazy_decode_bitmap.

https://codereview.chromium.org/16034015/diff/3/tools/pinspect.cpp
File tools/pinspect.cpp (right):

https://codereview.chromium.org/16034015/diff/3/tools/pinspect.cpp#newcode43
tools/pinspect.cpp:43: SkDebugf("Could not create SkPicture");
On 2013/06/12 12:03:11, caryclark wrote:
> include the path that failed in the printf, and terminate with a \n

Done.

https://codereview.chromium.org/16034015/diff/10001/gyp/tools.gyp
File gyp/tools.gyp (right):

https://codereview.chromium.org/16034015/diff/10001/gyp/tools.gyp#newcode277
gyp/tools.gyp:277: 'tools.gyp:picture_renderer',
Linking to flags was not enough because it doesn't have
PictureRenderingFlags.cpp (where lazy_decode_bitmap is defined) as a source.

Should I add PictureRenderingFlags.cpp as a source to flags.gyp:flags instead?

[scroggo, 2013-06-12 16:10:04]

lgtm

https://codereview.chromium.org/16034015/diff/10001/gyp/tools.gyp
File gyp/tools.gyp (right):

https://codereview.chromium.org/16034015/diff/10001/gyp/tools.gyp#newcode277
gyp/tools.gyp:277: 'tools.gyp:picture_renderer',
On 2013/06/12 15:37:37, sglez wrote:
> Linking to flags was not enough because it doesn't have
> PictureRenderingFlags.cpp (where lazy_decode_bitmap is defined) as a source.
> 
> Should I add PictureRenderingFlags.cpp as a source to flags.gyp:flags instead?

No, I was confused. PictureRenderingFlags should not be included by
flags.gyp:flags. I think this is fine, but please add a comment about why
picture_renderer is included.

https://codereview.chromium.org/16034015/diff/10001/tools/pinspect.cpp
File tools/pinspect.cpp (right):

https://codereview.chromium.org/16034015/diff/10001/tools/pinspect.cpp#newcode12
tools/pinspect.cpp:12: #include "SkImageDecoder.h"
I don't think this is needed now that you're not passing
SkImageDecoder::DecodeMemory to the SkPicture constructor

[commit-bot: I haz the power, 2013-06-12 18:20:25]

CQ is trying da patch. Follow status at
https://skia-tree-status.appspot.com/cq/sglez@google.com/16034015/10001

[commit-bot: I haz the power, 2013-06-12 18:28:39]

Change committed as 9538