Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(63)

Issue 16034007: Enable MediaSourceTest.* content_browsertests on Android. (Closed)

Created:
7 years, 6 months ago by scherkus (not reviewing)
Modified:
7 years, 6 months ago
CC:
chromium-reviews, craigdh+watch_chromium.org, jam, joi+watch-content_chromium.org, feature-media-reviews_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, ilevy-cc_chromium.org, darin-cc_chromium.org, klundberg+watch_chromium.org, frankf+watch_chromium.org
Visibility:
Public.

Description

Enable MediaSourceTest.* content_browsertests on Android. Sprinkling a little command line flag magic reveals these tests actually pass! BUG=243843 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=204634

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -9 lines) Patch
M build/android/pylib/gtest/filter/content_browsertests_disabled View 1 chunk +0 lines, -7 lines 0 comments Download
M content/browser/media/media_source_browsertest.cc View 1 3 chunks +12 lines, -1 line 0 comments Download
M content/public/common/content_switches.h View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (0 generated)
scherkus (not reviewing)
7 years, 6 months ago (2013-06-06 00:24:04 UTC) #1
acolwell GONE FROM CHROMIUM
lgtm
7 years, 6 months ago (2013-06-06 00:51:46 UTC) #2
gone
lgtm
7 years, 6 months ago (2013-06-06 00:52:36 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/scherkus@chromium.org/16034007/1
7 years, 6 months ago (2013-06-06 17:32:17 UTC) #4
commit-bot: I haz the power
Failed to apply patch for content/browser/media/media_source_browsertest.cc: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
7 years, 6 months ago (2013-06-06 17:32:20 UTC) #5
scherkus (not reviewing)
creis: OWNERS for content/public/common/content_switches.h
7 years, 6 months ago (2013-06-06 17:53:42 UTC) #6
Charlie Reis
content/public/common/content_switches.h LGTM.
7 years, 6 months ago (2013-06-06 18:01:06 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/scherkus@chromium.org/16034007/10001
7 years, 6 months ago (2013-06-06 18:05:36 UTC) #8
commit-bot: I haz the power
7 years, 6 months ago (2013-06-06 22:44:09 UTC) #9
Message was sent while issue was closed.
Change committed as 204634

Powered by Google App Engine
This is Rietveld 408576698