Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(140)

Side by Side Diff: chrome/renderer/extensions/web_request_custom_bindings.cc

Issue 16032015: Extensions: pass ChromeV8Context around instead of v8::Handle. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: rebased Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/renderer/extensions/web_request_custom_bindings.h" 5 #include "chrome/renderer/extensions/web_request_custom_bindings.h"
6 6
7 #include <string> 7 #include <string>
8 8
9 #include "base/bind.h" 9 #include "base/bind.h"
10 #include "base/strings/string_number_conversions.h" 10 #include "base/strings/string_number_conversions.h"
11 #include "grit/renderer_resources.h" 11 #include "grit/renderer_resources.h"
12 #include "v8/include/v8.h" 12 #include "v8/include/v8.h"
13 13
14 namespace extensions { 14 namespace extensions {
15 15
16 WebRequestCustomBindings::WebRequestCustomBindings( 16 WebRequestCustomBindings::WebRequestCustomBindings(
17 Dispatcher* dispatcher, v8::Handle<v8::Context> v8_context) 17 Dispatcher* dispatcher, ChromeV8Context* context)
18 : ChromeV8Extension(dispatcher, v8_context) { 18 : ChromeV8Extension(dispatcher, context) {
19 RouteFunction("GetUniqueSubEventName", 19 RouteFunction("GetUniqueSubEventName",
20 base::Bind(&WebRequestCustomBindings::GetUniqueSubEventName, 20 base::Bind(&WebRequestCustomBindings::GetUniqueSubEventName,
21 base::Unretained(this))); 21 base::Unretained(this)));
22 } 22 }
23 23
24 // Attach an event name to an object. 24 // Attach an event name to an object.
25 v8::Handle<v8::Value> WebRequestCustomBindings::GetUniqueSubEventName( 25 v8::Handle<v8::Value> WebRequestCustomBindings::GetUniqueSubEventName(
26 const v8::Arguments& args) { 26 const v8::Arguments& args) {
27 static int next_event_id = 0; 27 static int next_event_id = 0;
28 DCHECK(args.Length() == 1); 28 DCHECK(args.Length() == 1);
29 DCHECK(args[0]->IsString()); 29 DCHECK(args[0]->IsString());
30 std::string event_name(*v8::String::AsciiValue(args[0])); 30 std::string event_name(*v8::String::AsciiValue(args[0]));
31 std::string unique_event_name = 31 std::string unique_event_name =
32 event_name + "/" + base::IntToString(++next_event_id); 32 event_name + "/" + base::IntToString(++next_event_id);
33 return v8::String::New(unique_event_name.c_str()); 33 return v8::String::New(unique_event_name.c_str());
34 } 34 }
35 35
36 } // extensions 36 } // extensions
37
OLDNEW
« no previous file with comments | « chrome/renderer/extensions/web_request_custom_bindings.h ('k') | chrome/renderer/extensions/webstore_bindings.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698