Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(345)

Side by Side Diff: chrome/renderer/extensions/send_request_natives.cc

Issue 16032015: Extensions: pass ChromeV8Context around instead of v8::Handle. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: rebased Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/renderer/extensions/send_request_natives.h" 5 #include "chrome/renderer/extensions/send_request_natives.h"
6 6
7 #include "base/json/json_reader.h" 7 #include "base/json/json_reader.h"
8 #include "content/public/renderer/v8_value_converter.h" 8 #include "content/public/renderer/v8_value_converter.h"
9 #include "chrome/renderer/extensions/request_sender.h" 9 #include "chrome/renderer/extensions/request_sender.h"
10 10
11 using content::V8ValueConverter; 11 using content::V8ValueConverter;
12 12
13 namespace extensions { 13 namespace extensions {
14 14
15 SendRequestNatives::SendRequestNatives(Dispatcher* dispatcher, 15 SendRequestNatives::SendRequestNatives(Dispatcher* dispatcher,
16 RequestSender* request_sender, 16 RequestSender* request_sender,
17 ChromeV8Context* context) 17 ChromeV8Context* context)
18 : ChromeV8Extension(dispatcher, context->v8_context()), 18 : ChromeV8Extension(dispatcher, context),
19 request_sender_(request_sender), 19 request_sender_(request_sender) {
20 context_(context) {
21 RouteFunction("GetNextRequestId", 20 RouteFunction("GetNextRequestId",
22 base::Bind(&SendRequestNatives::GetNextRequestId, 21 base::Bind(&SendRequestNatives::GetNextRequestId,
23 base::Unretained(this))); 22 base::Unretained(this)));
24 RouteFunction("StartRequest", 23 RouteFunction("StartRequest",
25 base::Bind(&SendRequestNatives::StartRequest, 24 base::Bind(&SendRequestNatives::StartRequest,
26 base::Unretained(this))); 25 base::Unretained(this)));
27 RouteFunction("GetGlobal", 26 RouteFunction("GetGlobal",
28 base::Bind(&SendRequestNatives::GetGlobal, 27 base::Bind(&SendRequestNatives::GetGlobal,
29 base::Unretained(this))); 28 base::Unretained(this)));
30 } 29 }
(...skipping 15 matching lines...) Expand all
46 45
47 scoped_ptr<V8ValueConverter> converter(V8ValueConverter::create()); 46 scoped_ptr<V8ValueConverter> converter(V8ValueConverter::create());
48 47
49 // See http://crbug.com/149880. The context menus APIs relies on this, but 48 // See http://crbug.com/149880. The context menus APIs relies on this, but
50 // we shouldn't really be doing it (e.g. for the sake of the storage API). 49 // we shouldn't really be doing it (e.g. for the sake of the storage API).
51 converter->SetFunctionAllowed(true); 50 converter->SetFunctionAllowed(true);
52 51
53 if (!preserve_null_in_objects) 52 if (!preserve_null_in_objects)
54 converter->SetStripNullFromObjects(true); 53 converter->SetStripNullFromObjects(true);
55 54
56 scoped_ptr<Value> value_args(converter->FromV8Value(args[1], v8_context())); 55 scoped_ptr<Value> value_args(
56 converter->FromV8Value(args[1], context()->v8_context()));
57 if (!value_args.get() || !value_args->IsType(Value::TYPE_LIST)) { 57 if (!value_args.get() || !value_args->IsType(Value::TYPE_LIST)) {
58 NOTREACHED() << "Unable to convert args passed to StartRequest"; 58 NOTREACHED() << "Unable to convert args passed to StartRequest";
59 return v8::Undefined(); 59 return v8::Undefined();
60 } 60 }
61 61
62 request_sender_->StartRequest( 62 request_sender_->StartRequest(
63 context_, name, request_id, has_callback, for_io_thread, 63 context(), name, request_id, has_callback, for_io_thread,
64 static_cast<ListValue*>(value_args.get())); 64 static_cast<ListValue*>(value_args.get()));
65 return v8::Undefined(); 65 return v8::Undefined();
66 } 66 }
67 67
68 v8::Handle<v8::Value> SendRequestNatives::GetGlobal(const v8::Arguments& args) { 68 v8::Handle<v8::Value> SendRequestNatives::GetGlobal(const v8::Arguments& args) {
69 CHECK_EQ(1, args.Length()); 69 CHECK_EQ(1, args.Length());
70 CHECK(args[0]->IsObject()); 70 CHECK(args[0]->IsObject());
71 return v8::Handle<v8::Object>::Cast(args[0])->CreationContext()->Global(); 71 return v8::Handle<v8::Object>::Cast(args[0])->CreationContext()->Global();
72 } 72 }
73 73
74 } // namespace extensions 74 } // namespace extensions
OLDNEW
« no previous file with comments | « chrome/renderer/extensions/send_request_natives.h ('k') | chrome/renderer/extensions/set_icon_natives.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698