Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(396)

Side by Side Diff: chrome/renderer/extensions/object_backed_native_handler.cc

Issue 16032015: Extensions: pass ChromeV8Context around instead of v8::Handle. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: rebased Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/renderer/extensions/object_backed_native_handler.h" 5 #include "chrome/renderer/extensions/object_backed_native_handler.h"
6 6
7 #include "base/logging.h" 7 #include "base/logging.h"
8 #include "base/memory/linked_ptr.h" 8 #include "base/memory/linked_ptr.h"
9 #include "chrome/renderer/extensions/chrome_v8_context.h"
9 #include "chrome/renderer/extensions/console.h" 10 #include "chrome/renderer/extensions/console.h"
10 #include "chrome/renderer/extensions/module_system.h" 11 #include "chrome/renderer/extensions/module_system.h"
11 #include "v8/include/v8.h" 12 #include "v8/include/v8.h"
12 13
13 namespace extensions { 14 namespace extensions {
14 15
15 namespace { 16 namespace {
16 // Key for the base::Bound routed function. 17 // Key for the base::Bound routed function.
17 const char* kHandlerFunction = "handler_function"; 18 const char* kHandlerFunction = "handler_function";
18 } // namespace 19 } // namespace
19 20
20 ObjectBackedNativeHandler::ObjectBackedNativeHandler( 21 ObjectBackedNativeHandler::ObjectBackedNativeHandler(
21 v8::Handle<v8::Context> context) 22 ChromeV8Context* context)
22 : v8_context_(context), 23 : context_(context),
23 object_template_(v8::ObjectTemplate::New()) { 24 object_template_(v8::ObjectTemplate::New()) {
24 } 25 }
25 26
26 ObjectBackedNativeHandler::~ObjectBackedNativeHandler() { 27 ObjectBackedNativeHandler::~ObjectBackedNativeHandler() {
27 Invalidate(); 28 Invalidate();
28 } 29 }
29 30
30 v8::Handle<v8::Object> ObjectBackedNativeHandler::NewInstance() { 31 v8::Handle<v8::Object> ObjectBackedNativeHandler::NewInstance() {
31 return object_template_->NewInstance(); 32 return object_template_->NewInstance();
32 } 33 }
(...skipping 15 matching lines...) Expand all
48 } 49 }
49 DCHECK(handler_function_value->IsExternal()); 50 DCHECK(handler_function_value->IsExternal());
50 return handle_scope.Close(static_cast<HandlerFunction*>( 51 return handle_scope.Close(static_cast<HandlerFunction*>(
51 handler_function_value.As<v8::External>()->Value())->Run(args)); 52 handler_function_value.As<v8::External>()->Value())->Run(args));
52 } 53 }
53 54
54 void ObjectBackedNativeHandler::RouteFunction( 55 void ObjectBackedNativeHandler::RouteFunction(
55 const std::string& name, 56 const std::string& name,
56 const HandlerFunction& handler_function) { 57 const HandlerFunction& handler_function) {
57 v8::HandleScope handle_scope; 58 v8::HandleScope handle_scope;
58 v8::Context::Scope context_scope(v8_context_.get()); 59 v8::Context::Scope context_scope(context_->v8_context());
59 60
60 v8::Persistent<v8::Object> data(v8_context_->GetIsolate(), v8::Object::New()); 61 v8::Persistent<v8::Object> data(context_->v8_context()->GetIsolate(),
62 v8::Object::New());
61 data->Set(v8::String::New(kHandlerFunction), 63 data->Set(v8::String::New(kHandlerFunction),
62 v8::External::New(new HandlerFunction(handler_function))); 64 v8::External::New(new HandlerFunction(handler_function)));
63 router_data_.push_back(data); 65 router_data_.push_back(data);
64 v8::Handle<v8::FunctionTemplate> function_template = 66 v8::Handle<v8::FunctionTemplate> function_template =
65 v8::FunctionTemplate::New(Router, data); 67 v8::FunctionTemplate::New(Router, data);
66 object_template_->Set(name.c_str(), function_template); 68 object_template_->Set(name.c_str(), function_template);
67 } 69 }
68 70
69 void ObjectBackedNativeHandler::Invalidate() { 71 void ObjectBackedNativeHandler::Invalidate() {
70 if (!is_valid()) 72 if (!is_valid())
71 return; 73 return;
72 v8::HandleScope handle_scope; 74 v8::HandleScope handle_scope;
73 v8::Context::Scope context_scope(v8_context_.get()); 75 v8::Context::Scope context_scope(context_->v8_context());
74 76
75 for (RouterData::iterator it = router_data_.begin(); 77 for (RouterData::iterator it = router_data_.begin();
76 it != router_data_.end(); ++it) { 78 it != router_data_.end(); ++it) {
77 v8::Persistent<v8::Object> data = *it; 79 v8::Persistent<v8::Object> data = *it;
78 v8::Handle<v8::Value> handler_function_value = 80 v8::Handle<v8::Value> handler_function_value =
79 data->Get(v8::String::New(kHandlerFunction)); 81 data->Get(v8::String::New(kHandlerFunction));
80 CHECK(!handler_function_value.IsEmpty()); 82 CHECK(!handler_function_value.IsEmpty());
81 delete static_cast<HandlerFunction*>( 83 delete static_cast<HandlerFunction*>(
82 handler_function_value.As<v8::External>()->Value()); 84 handler_function_value.As<v8::External>()->Value());
83 data->Delete(v8::String::New(kHandlerFunction)); 85 data->Delete(v8::String::New(kHandlerFunction));
84 data.Dispose(v8_context_->GetIsolate()); 86 data.Dispose(context_->v8_context()->GetIsolate());
85 } 87 }
86 object_template_.reset(); 88 object_template_.reset();
87 v8_context_.reset(); 89 context_ = NULL;
88 NativeHandler::Invalidate(); 90 NativeHandler::Invalidate();
89 } 91 }
90 92
91 } // extensions 93 } // extensions
OLDNEW
« no previous file with comments | « chrome/renderer/extensions/object_backed_native_handler.h ('k') | chrome/renderer/extensions/page_actions_custom_bindings.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698