Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(260)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 16025007: Refacotring: fix styles of i18n-content names. (Closed)

Created:
7 years, 6 months ago by hajimehoshi
Modified:
7 years, 6 months ago
Reviewers:
Evan Stade
CC:
chromium-reviews, dbeam+watch-options_chromium.org, yusukes+watch_chromium.org, nona+watch_chromium.org, arv+watch_chromium.org, oshima+watch_chromium.org, stevenjb+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Refacotring: fix styles of i18n-content names (concerned with the language options). Replaced i18n-content names from c_hacker_style to camelCaseStyle except for some names which are generated by chromeos::options::GetI18nContentValue. This CL is forked from https://codereview.chromium.org/16141002/. BTW, I couldn't find where the below names are used: - extension_ime_description - extension_ime_label Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=203142

Patch Set 1 #

Patch Set 2 : (Rebasing) #

Patch Set 3 : Bug fix #

Messages

Total messages: 9 (0 generated)
hajimehoshi
Can you take a look? Thank you in advance.
7 years, 6 months ago (2013-05-29 04:40:13 UTC) #1
Evan Stade
lgtm, thanks
7 years, 6 months ago (2013-05-29 22:50:29 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hajimehoshi@chromium.org/16025007/4001
7 years, 6 months ago (2013-05-30 03:09:53 UTC) #3
commit-bot: I haz the power
Retried try job too often on linux_aura for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_aura&number=45111
7 years, 6 months ago (2013-05-30 05:15:34 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hajimehoshi@chromium.org/16025007/3002
7 years, 6 months ago (2013-05-30 06:20:26 UTC) #5
commit-bot: I haz the power
Retried try job too often on linux_chromeos for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chromeos&number=119954
7 years, 6 months ago (2013-05-30 08:41:51 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hajimehoshi@chromium.org/16025007/3002
7 years, 6 months ago (2013-05-30 08:54:20 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hajimehoshi@chromium.org/16025007/3002
7 years, 6 months ago (2013-05-30 11:20:04 UTC) #8
commit-bot: I haz the power
7 years, 6 months ago (2013-05-30 14:17:13 UTC) #9
Message was sent while issue was closed. 
Change committed as 203142

Powered by Google App Engine
This is Rietveld 408576698