Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1500)

Unified Diff: public/platform/WebPrivatePtr.h

Issue 16024011: Construct a minimal blink library in-place (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: fix mac again Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « public/platform/WebPrivateOwnPtr.h ('k') | public/platform/WebString.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: public/platform/WebPrivatePtr.h
diff --git a/public/platform/WebPrivatePtr.h b/public/platform/WebPrivatePtr.h
index 7afa43688bf571014c32919f7325d71a9f6f9eb0..fa5e340d14d2d1badf387c5d327c36754fe823f8 100644
--- a/public/platform/WebPrivatePtr.h
+++ b/public/platform/WebPrivatePtr.h
@@ -33,7 +33,7 @@
#include "WebCommon.h"
-#if WEBKIT_IMPLEMENTATION
+#if INSIDE_WEBKIT
#include <wtf/PassRefPtr.h>
#endif
@@ -63,8 +63,8 @@ namespace WebKit {
// WEBKIT_EXPORT doWebFooThing();
//
// // Methods that are used only by other WebKit/chromium API classes
-// // should only be declared when WEBKIT_IMPLEMENTATION is set.
-// #if WEBKIT_IMPLEMENTATION
+// // should only be declared when INSIDE_WEBKIT is set.
+// #if INSIDE_WEBKIT
// WebFoo(const WTF::PassRefPtr<WebCore::Foo>&);
// #endif
//
@@ -80,7 +80,7 @@ public:
bool isNull() const { return !m_ptr; }
-#if WEBKIT_IMPLEMENTATION
+#if INSIDE_WEBKIT
WebPrivatePtr(const PassRefPtr<T>& prp)
: m_ptr(prp.leakRef())
{
@@ -119,7 +119,7 @@ public:
#endif
private:
-#if WEBKIT_IMPLEMENTATION
+#if INSIDE_WEBKIT
void assign(T* p)
{
// p is already ref'd for us by the caller
@@ -129,7 +129,7 @@ private:
}
#else
// Disable the assignment operator; we define it above for when
- // WEBKIT_IMPLEMENTATION is set, but we need to make sure that it is not
+ // INSIDE_WEBKIT is set, but we need to make sure that it is not
// used outside there; the compiler-provided version won't handle reference
// counting properly.
WebPrivatePtr<T>& operator=(const WebPrivatePtr<T>& other);
« no previous file with comments | « public/platform/WebPrivateOwnPtr.h ('k') | public/platform/WebString.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698