Lower the I/O priority of the installer when resonable.

Lower the I/O priority of the installer when resonable.

On operating systems that support it (Vista+), begin background
processing mode before doing major disk I/O in the installer if it was
launched below the normal process priority class. One hopes that this
avoids making users' machines unresponsive while an update is being
applied in the background.

BUG=167622
TEST=mostly covered by "setup_unittests.exe
--gtest_filter=SetupUtilTest.Adjust*", but it will also be interesting
to look at verbose installer log files for an install and for a Google
Update-driven update. Only the latter should contain "Entered background
processing mode."

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=203982

[cpu_(ooo_6.6-7.5), 2013-05-31 19:09:49]

https://codereview.chromium.org/16023027/diff/8001/chrome/installer/setup/run...
File chrome/installer/setup/run_all_unittests.cc (right):

https://codereview.chromium.org/16023027/diff/8001/chrome/installer/setup/run...
chrome/installer/setup/run_all_unittests.cc:16: return
DoProcessPriorityAdjustment();
return  here ?

[grt (UTC plus 2), 2013-06-01 01:38:33]

https://codereview.chromium.org/16023027/diff/8001/chrome/installer/setup/run...
File chrome/installer/setup/run_all_unittests.cc (right):

https://codereview.chromium.org/16023027/diff/8001/chrome/installer/setup/run...
chrome/installer/setup/run_all_unittests.cc:16: return
DoProcessPriorityAdjustment();
On 2013/05/31 19:09:49, cpu wrote:
> return  here ?

Right. The idea is that when setup_unittests.exe is run with
--adjust-process-priority, it does nothing more than check the current priority
class and lower to background processing mode if relevant, and returns an exit
code indicating what it did (without running any unittests). This is triggered
by the new tests (SetupUtilTest.AdjustFromNormalPriority and
SetupUtilTest.AdjustFromBelowNormalPriority).

To re-state: running "setup_unittests --gtest_filter=SetupUtilTest.Adjust*" will
re-invoke setup_unittests with --adjust-process-priority (twice: once for each
test) to verify that installer::AdjustProcessPriority() can successfully drop to
bg mode where appropriate. Make sense?

[cpu_(ooo_6.6-7.5), 2013-06-03 19:43:02]

lgtm

I overlooked the test initially. my bad.

https://codereview.chromium.org/16023027/diff/8001/chrome/installer/setup/set...
File chrome/installer/setup/setup_main.cc (right):

https://codereview.chromium.org/16023027/diff/8001/chrome/installer/setup/set...
chrome/installer/setup/setup_main.cc:644: VLOG_IF(1,
installer::AdjustProcessPriority())
I am always scared of calling actuall code inside logging macros. Eventually
somebody is going to create a configuration where this is a no op.

https://codereview.chromium.org/16023027/diff/8001/chrome/installer/setup/set...
File chrome/installer/setup/setup_util.cc (right):

https://codereview.chromium.org/16023027/diff/8001/chrome/installer/setup/set...
chrome/installer/setup/setup_util.cc:318: if (base::win::GetVersion() >
base::win::VERSION_SERVER_2003) {
can we use VERSION_VISTA ? in general we try our best to ignore server versions
unless the thing explodes if we do.

https://codereview.chromium.org/16023027/diff/8001/chrome/installer/setup/set...
chrome/installer/setup/setup_util.cc:328: return !!result;
note that GetCurrentProcess just returns -1 so it is ok to call that every time
like in line 325. Just a suggestion here.

[grt (UTC plus 2), 2013-06-03 20:13:17]

Thanks.

https://codereview.chromium.org/16023027/diff/8001/chrome/installer/setup/set...
File chrome/installer/setup/setup_main.cc (right):

https://codereview.chromium.org/16023027/diff/8001/chrome/installer/setup/set...
chrome/installer/setup/setup_main.cc:644: VLOG_IF(1,
installer::AdjustProcessPriority())
On 2013/06/03 19:43:02, cpu wrote:
> I am always scared of calling actuall code inside logging macros. Eventually
> somebody is going to create a configuration where this is a no op.

Done.

https://codereview.chromium.org/16023027/diff/8001/chrome/installer/setup/set...
File chrome/installer/setup/setup_util.cc (right):

https://codereview.chromium.org/16023027/diff/8001/chrome/installer/setup/set...
chrome/installer/setup/setup_util.cc:318: if (base::win::GetVersion() >
base::win::VERSION_SERVER_2003) {
On 2013/06/03 19:43:02, cpu wrote:
> can we use VERSION_VISTA ? in general we try our best to ignore server
versions
> unless the thing explodes if we do.

Done.

https://codereview.chromium.org/16023027/diff/8001/chrome/installer/setup/set...
chrome/installer/setup/setup_util.cc:328: return !!result;
On 2013/06/03 19:43:02, cpu wrote:
> note that GetCurrentProcess just returns -1 so it is ok to call that every
time
> like in line 325. Just a suggestion here.

Done.

[commit-bot: I haz the power, 2013-06-03 20:13:50]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/grt@chromium.org/16023027/17001

[commit-bot: I haz the power, 2013-06-04 02:14:26]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/grt@chromium.org/16023027/17001

[commit-bot: I haz the power, 2013-06-04 15:26:07]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/grt@chromium.org/16023027/17001

[commit-bot: I haz the power, 2013-06-04 16:50:32]

Change committed as 203982