Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(140)

Issue 16023012: [content shell] protect against the case when a RPH dies before the process launched (Closed)

Created:
7 years, 7 months ago by jochen (gone - plz use gerrit)
Modified:
7 years, 7 months ago
Reviewers:
marja, abarth-chromium
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, jochen+watch_chromium.org
Visibility:
Public.

Description

[content shell] protect against the case when a RPH dies before the process launched e.g. http/tests/xmlhttprequest/access-control-repeated-failed-preflight-crash.html quickly opens and closes the devtools. If a new RPH is then created and happens to be at the same location, we'll register twice for the process created notification. BUG=111316 R=marja@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=202465

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -0 lines) Patch
M content/shell/shell_content_browser_client.cc View 3 chunks +16 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
jochen (gone - plz use gerrit)
7 years, 7 months ago (2013-05-27 15:35:00 UTC) #1
abarth-chromium
LGTM. This looks pretty error prone...
7 years, 7 months ago (2013-05-27 18:38:55 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jochen@chromium.org/16023012/1
7 years, 7 months ago (2013-05-27 18:39:37 UTC) #3
abarth-chromium
Do non-ContentShell targets have the same bug?
7 years, 7 months ago (2013-05-27 18:40:17 UTC) #4
jochen (gone - plz use gerrit)
no, this is test-only code.
7 years, 7 months ago (2013-05-27 18:44:07 UTC) #5
commit-bot: I haz the power
7 years, 7 months ago (2013-05-27 21:23:55 UTC) #6
Message was sent while issue was closed.
Change committed as 202465

Powered by Google App Engine
This is Rietveld 408576698