Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(770)

Issue 16023005: Add HasClickedListener to the notification delegate in background_content_service. (Closed)

Created:
7 years, 7 months ago by Jun Mukai
Modified:
7 years, 6 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Add HasClickedListener to the notification delegate in background_content_service. This method was added at r201847 to indicate a notification can be clickable or not (by changing mouse cursor, for now). BUG=241266 TEST=none R=atwilson@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=202613

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M chrome/browser/background/background_contents_service.cc View 1 chunk +2 lines, -0 lines 2 comments Download

Messages

Total messages: 6 (0 generated)
Jun Mukai
7 years, 7 months ago (2013-05-24 20:31:14 UTC) #1
Andrew T Wilson (Slow)
LGTM with one nit - I'd like a comment in the code describing why this ...
7 years, 6 months ago (2013-05-27 12:36:50 UTC) #2
Jun Mukai
https://codereview.chromium.org/16023005/diff/1/chrome/browser/background/background_contents_service.cc File chrome/browser/background/background_contents_service.cc (right): https://codereview.chromium.org/16023005/diff/1/chrome/browser/background/background_contents_service.cc#newcode107 chrome/browser/background/background_contents_service.cc:107: virtual bool HasClickedListener() OVERRIDE { return true; } On ...
7 years, 6 months ago (2013-05-27 19:10:28 UTC) #3
Andrew T Wilson (Slow)
On 2013/05/27 19:10:28, Jun Mukai wrote: > https://codereview.chromium.org/16023005/diff/1/chrome/browser/background/background_contents_service.cc > File chrome/browser/background/background_contents_service.cc (right): > > https://codereview.chromium.org/16023005/diff/1/chrome/browser/background/background_contents_service.cc#newcode107 ...
7 years, 6 months ago (2013-05-28 07:27:57 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mukai@chromium.org/16023005/1
7 years, 6 months ago (2013-05-28 16:24:39 UTC) #5
commit-bot: I haz the power
7 years, 6 months ago (2013-05-28 18:47:38 UTC) #6
Message was sent while issue was closed.
Change committed as 202613

Powered by Google App Engine
This is Rietveld 408576698