Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(876)

Issue 16022005: [NaCl SDK] Add keyboard interrupt handlers for python scripts (Closed)

Created:
7 years, 7 months ago by Sam Clegg
Modified:
7 years, 7 months ago
Reviewers:
binji
CC:
chromium-reviews, binji, Sam Clegg
Visibility:
Public.

Description

[NaCl SDK] Add keyboard interrupt handlers for python scripts This means that users (and developers) who hit ctrl-C while running out scripts don't see ugly python backtraces and get exposed to implementation details. Also, fix inconsisency in download.py regarding the progess callback. BUG=None Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=202335

Patch Set 1 #

Total comments: 6

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+59 lines, -26 lines) Patch
M native_client_sdk/src/build_tools/build_projects.py View 1 1 chunk +4 lines, -1 line 0 comments Download
M native_client_sdk/src/build_tools/build_sdk.py View 1 chunk +4 lines, -1 line 0 comments Download
M native_client_sdk/src/build_tools/buildbot_run.py View 1 chunk +4 lines, -1 line 0 comments Download
M native_client_sdk/src/build_tools/sdk_tools/download.py View 4 chunks +19 lines, -17 lines 0 comments Download
M native_client_sdk/src/build_tools/sdk_tools/sdk_update.py View 1 chunk +4 lines, -1 line 0 comments Download
M native_client_sdk/src/build_tools/sdk_tools/sdk_update_main.py View 1 chunk +3 lines, -0 lines 0 comments Download
M native_client_sdk/src/build_tools/test_sdk.py View 1 chunk +4 lines, -1 line 0 comments Download
M native_client_sdk/src/tools/create_nmf.py View 2 chunks +9 lines, -0 lines 0 comments Download
M native_client_sdk/src/tools/oshelpers.py View 1 1 chunk +8 lines, -3 lines 0 comments Download
M native_client_sdk/src/tools/tests/oshelpers_test.py View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
binji
lgtm https://codereview.chromium.org/16022005/diff/1/native_client_sdk/src/build_tools/build_projects.py File native_client_sdk/src/build_tools/build_projects.py (right): https://codereview.chromium.org/16022005/diff/1/native_client_sdk/src/build_tools/build_projects.py#newcode253 native_client_sdk/src/build_tools/build_projects.py:253: buildbot_common.ErrorExit('build_projects: interrupted') maybe just use sys.argv[0]? https://codereview.chromium.org/16022005/diff/1/native_client_sdk/src/tools/create_nmf.py File ...
7 years, 7 months ago (2013-05-24 19:13:04 UTC) #1
Sam Clegg
https://codereview.chromium.org/16022005/diff/1/native_client_sdk/src/build_tools/build_projects.py File native_client_sdk/src/build_tools/build_projects.py (right): https://codereview.chromium.org/16022005/diff/1/native_client_sdk/src/build_tools/build_projects.py#newcode253 native_client_sdk/src/build_tools/build_projects.py:253: buildbot_common.ErrorExit('build_projects: interrupted') On 2013/05/24 19:13:04, binji wrote: > maybe ...
7 years, 7 months ago (2013-05-24 21:21:44 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sbc@chromium.org/16022005/6001
7 years, 7 months ago (2013-05-25 01:25:00 UTC) #3
commit-bot: I haz the power
7 years, 7 months ago (2013-05-26 02:34:18 UTC) #4
Message was sent while issue was closed.
Change committed as 202335

Powered by Google App Engine
This is Rietveld 408576698