Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Issue 16021009: Redo display of web contents modal dialog under the bookmark bar (Closed)

Created:
7 years, 7 months ago by Mike Wittman
Modified:
7 years, 6 months ago
CC:
chromium-reviews, tfarina, Rune Fevang, Vitaly Buka (NO REVIEWS)
Visibility:
Public.

Description

Redo display of web contents modal dialog under the bookmark bar This change was made in http://crrev.com/200122, but appears to have been lost in a merge at http://crrev.com/200407. BUG=243275 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=202681

Patch Set 1 #

Patch Set 2 : Handle detached bookmarks bar #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -7 lines) Patch
M chrome/browser/ui/views/frame/browser_view_layout.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/frame/browser_view_layout.cc View 1 3 chunks +10 lines, -6 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
Mike Wittman
7 years, 7 months ago (2013-05-24 21:24:08 UTC) #1
Vitaly Buka (NO REVIEWS)
On 2013/05/24 21:24:08, Mike Wittman wrote: this resoles bookmarks but infobar is still a problem ...
7 years, 7 months ago (2013-05-25 01:42:39 UTC) #2
Mike Wittman
On 2013/05/25 01:42:39, Vitaly Buka wrote: > On 2013/05/24 21:24:08, Mike Wittman wrote: > > ...
7 years, 6 months ago (2013-05-28 17:01:33 UTC) #3
Ben Goodger (Google)
lgtm
7 years, 6 months ago (2013-05-28 17:06:57 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wittman@chromium.org/16021009/4001
7 years, 6 months ago (2013-05-28 17:08:36 UTC) #5
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) chrome_frame_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=154632
7 years, 6 months ago (2013-05-28 22:10:43 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wittman@chromium.org/16021009/4001
7 years, 6 months ago (2013-05-28 22:14:46 UTC) #7
commit-bot: I haz the power
7 years, 6 months ago (2013-05-28 23:13:00 UTC) #8
Message was sent while issue was closed.
Change committed as 202681

Powered by Google App Engine
This is Rietveld 408576698