Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issue 16020003: Blink-side Device Motion API testing. (Closed)

Created:
7 years, 7 months ago by timvolodine
Modified:
7 years, 5 months ago
Reviewers:
abarth-chromium
CC:
blink-reviews, jamesr, eae+blinkwatch, jochen+watch_chromium.org, abarth-chromium
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Blink-side Device Motion API testing. In this testing approach we inject a mock device motion data object into platform and catch the 'ondevicemotion' event in Javascript, with that same data. BUG=135804 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=154502

Patch Set 1 #

Patch Set 2 : revisited implementation #

Patch Set 3 : added test files #

Patch Set 4 : fix diff #

Patch Set 5 : rebased #

Patch Set 6 : rebase #

Patch Set 7 : fixed other device motion tests #

Patch Set 8 : fixed window-property Layout test #

Patch Set 9 : fixed window-property layout test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+191 lines, -74 lines) Patch
A + LayoutTests/fast/dom/DeviceMotion/add-listener-from-callback.html View 2 3 0 chunks +-1 lines, --1 lines 0 comments Download
A LayoutTests/fast/dom/DeviceMotion/add-listener-from-callback-expected.txt View 1 2 1 chunk +20 lines, -0 lines 0 comments Download
M LayoutTests/fast/dom/DeviceMotion/create-event-expected.txt View 1 2 3 4 5 6 1 chunk +8 lines, -8 lines 0 comments Download
M LayoutTests/fast/dom/DeviceMotion/optional-event-properties-expected.txt View 1 2 3 4 5 6 1 chunk +46 lines, -57 lines 0 comments Download
A LayoutTests/fast/dom/DeviceMotion/script-tests/add-listener-from-callback.js View 1 2 1 chunk +50 lines, -0 lines 0 comments Download
M LayoutTests/fast/dom/DeviceMotion/window-property-expected.txt View 1 2 3 4 5 6 7 1 chunk +6 lines, -6 lines 0 comments Download
M LayoutTests/fast/dom/Window/window-properties-device-orientation-expected.txt View 1 2 3 4 5 6 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/webexposed/global-constructors-listing-expected.txt View 1 2 3 4 5 6 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/page/RuntimeEnabledFeatures.in View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M Tools/DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp View 1 1 chunk +3 lines, -0 lines 0 comments Download
M Tools/DumpRenderTree/chromium/TestRunner/src/TestRunner.h View 1 2 3 4 1 chunk +2 lines, -1 line 0 comments Download
M Tools/DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp View 1 2 3 4 3 chunks +50 lines, -0 lines 0 comments Download
M public/testing/WebTestDelegate.h View 1 2 chunks +3 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
timvolodine
7 years, 5 months ago (2013-07-12 14:52:45 UTC) #1
abarth-chromium
lgtm
7 years, 5 months ago (2013-07-12 23:17:09 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/timvolodine@chromium.org/16020003/11001
7 years, 5 months ago (2013-07-16 20:59:06 UTC) #3
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 5 months ago (2013-07-16 23:29:02 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/timvolodine@chromium.org/16020003/28009
7 years, 5 months ago (2013-07-18 17:26:20 UTC) #5
commit-bot: I haz the power
7 years, 5 months ago (2013-07-18 18:39:06 UTC) #6
Message was sent while issue was closed.
Change committed as 154502

Powered by Google App Engine
This is Rietveld 408576698