Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1162)

Unified Diff: Source/core/rendering/TextAutosizer.cpp

Issue 16019004: Text Autosizing: Treat position:absolute/fixed as constrained height. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « LayoutTests/fast/text-autosizing/positioned-out-of-flow-expected.html ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/rendering/TextAutosizer.cpp
diff --git a/Source/core/rendering/TextAutosizer.cpp b/Source/core/rendering/TextAutosizer.cpp
index d34593f5fb20f1e238e980e52fa2b7a704e53b8d..d6f23bdbaca8d3ba46ee5ee687cb9c59fb33866d 100644
--- a/Source/core/rendering/TextAutosizer.cpp
+++ b/Source/core/rendering/TextAutosizer.cpp
@@ -446,12 +446,12 @@ bool TextAutosizer::contentHeightIsConstrained(const RenderBlock* container)
RenderStyle* style = container->style();
if (style->overflowY() >= OSCROLL)
return false;
- if (style->height().isSpecified() || style->maxHeight().isSpecified()) {
+ if (style->height().isSpecified() || style->maxHeight().isSpecified() || container->isOutOfFlowPositioned()) {
// Some sites (e.g. wikipedia) set their html and/or body elements to height:100%,
// without intending to constrain the height of the content within them.
return !container->isRoot() && !container->isBody();
}
- if (container->isFloatingOrOutOfFlowPositioned())
+ if (container->isFloating())
return false;
}
return false;
« no previous file with comments | « LayoutTests/fast/text-autosizing/positioned-out-of-flow-expected.html ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698