Files.app: Added an Esc key handler to the search box.

Files.app: Added an Esc key handler to the search box.

This CL added an Esc key handler to the search box, which sets the focus to main
view (the file list or the thumbnail grid) when the search box has no query.

BUG=239307
TEST=manually

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=202551

[hirono, 2013-05-28 01:49:22]

@mtomasz-san,

Could you check the CL?
Thank you!

[mtomasz, 2013-05-28 04:07:06]

https://codereview.chromium.org/16018008/diff/1/chrome/browser/resources/file...
File chrome/browser/resources/file_manager/js/file_manager.js (right):

https://codereview.chromium.org/16018008/diff/1/chrome/browser/resources/file...
chrome/browser/resources/file_manager/js/file_manager.js:3528: * Handled to
special key such as ESC.
We usually start with a passive verb.
Eg. Handles special keys such as Escape on the search box.

https://codereview.chromium.org/16018008/diff/1/chrome/browser/resources/file...
chrome/browser/resources/file_manager/js/file_manager.js:3529: * Normal text
inputs should not be handled by this, should be handled by
I think that the second line is confusing. The first is enough. Please remove.

https://codereview.chromium.org/16018008/diff/1/chrome/browser/resources/file...
chrome/browser/resources/file_manager/js/file_manager.js:3532: * @param {Event}
event The 'keydown' event.
Without '' for consistency.

https://codereview.chromium.org/16018008/diff/1/chrome/browser/resources/file...
chrome/browser/resources/file_manager/js/file_manager.js:3543: // The grid not
selects its item when focused.
not selects -> does not select

https://codereview.chromium.org/16018008/diff/1/chrome/browser/resources/file...
chrome/browser/resources/file_manager/js/file_manager.js:3544: if
(this.grid_.dataModel.length != 0)
Shall we do it for the table list too?

[hirono, 2013-05-28 04:24:26]

Fixed. Thank you!

https://codereview.chromium.org/16018008/diff/1/chrome/browser/resources/file...
File chrome/browser/resources/file_manager/js/file_manager.js (right):

https://codereview.chromium.org/16018008/diff/1/chrome/browser/resources/file...
chrome/browser/resources/file_manager/js/file_manager.js:3528: * Handled to
special key such as ESC.
On 2013/05/28 04:07:06, mtomasz wrote:
> We usually start with a passive verb.
> Eg. Handles special keys such as Escape on the search box. 

Done.

https://codereview.chromium.org/16018008/diff/1/chrome/browser/resources/file...
chrome/browser/resources/file_manager/js/file_manager.js:3529: * Normal text
inputs should not be handled by this, should be handled by
On 2013/05/28 04:07:06, mtomasz wrote:
> I think that the second line is confusing. The first is enough. Please remove.

Done.

https://codereview.chromium.org/16018008/diff/1/chrome/browser/resources/file...
chrome/browser/resources/file_manager/js/file_manager.js:3532: * @param {Event}
event The 'keydown' event.
On 2013/05/28 04:07:06, mtomasz wrote:
> Without '' for consistency.

Done.

https://codereview.chromium.org/16018008/diff/1/chrome/browser/resources/file...
chrome/browser/resources/file_manager/js/file_manager.js:3543: // The grid not
selects its item when focused.
On 2013/05/28 04:07:06, mtomasz wrote:
> not selects -> does not select

Done.

https://codereview.chromium.org/16018008/diff/1/chrome/browser/resources/file...
chrome/browser/resources/file_manager/js/file_manager.js:3544: if
(this.grid_.dataModel.length != 0)
On 2013/05/28 04:07:06, mtomasz wrote:
> Shall we do it for the table list too?

Done.

[mtomasz, 2013-05-28 10:32:11]

lgtm, sorry for the delay!

[commit-bot: I haz the power, 2013-05-28 11:02:09]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/hirono@chromium.org/16018008/5001

[hirono, 2013-05-28 11:05:52]

On 2013/05/28 10:32:11, mtomasz wrote:
> lgtm, sorry for the delay!

Thank you very much!

[commit-bot: I haz the power, 2013-05-28 13:53:26]

Change committed as 202551