Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(120)

Issue 16018007: Removed suppression for bug 243963. (Closed)

Created:
7 years, 7 months ago by Joao da Silva
Modified:
7 years, 6 months ago
CC:
chromium-reviews, glider+watch_chromium.org, timurrrr+watch_chromium.org, bruening+watch_chromium.org
Visibility:
Public.

Description

Removed suppression for bug 243963. This was a race because PolicyDomainDescriptors are passed from the UI to the FILE thread in scoped_refptrs, but the class derived from RefCounted instead of RefCountedThreadSafe. The fix was in http://crrev.com/202452. BUG=243963 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=202520

Patch Set 1 #

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -23 lines) Patch
M tools/valgrind/tsan/suppressions.txt View 1 chunk +0 lines, -23 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Joao da Silva
This CL just removes the suppressions. I got buildbot reports about other issues caused by ...
7 years, 7 months ago (2013-05-27 22:15:13 UTC) #1
Derek Bruening
lgtm
7 years, 7 months ago (2013-05-28 03:10:31 UTC) #2
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
7 years, 6 months ago (2013-05-28 06:15:09 UTC) #3
Joao da Silva
7 years, 6 months ago (2013-05-28 06:15:38 UTC) #4
pneubeck (no reviews)
lgtm
7 years, 6 months ago (2013-05-28 06:16:12 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/joaodasilva@chromium.org/16018007/2001
7 years, 6 months ago (2013-05-28 06:16:21 UTC) #6
commit-bot: I haz the power
7 years, 6 months ago (2013-05-28 09:11:31 UTC) #7
Message was sent while issue was closed.
Change committed as 202520

Powered by Google App Engine
This is Rietveld 408576698