Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(159)

Issue 16018006: Generate tap gesture with tap_count = 3 for triple-tap (Closed)

Created:
7 years, 6 months ago by Yufeng Shen (Slow to review)
Modified:
7 years, 6 months ago
Reviewers:
sadrul, sky
CC:
chromium-reviews, sadrul, ben+watch_chromium.org
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Generate tap gesture with tap_count = 3 for triple-tap This is to make triple-tap select a paragraph. BUG=236402 TEST=triple-tap on a paragraph and make sure the whole paragraph is selected. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=202735

Patch Set 1 #

Total comments: 6

Patch Set 2 : refator #

Total comments: 1

Patch Set 3 : fix sky's comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+90 lines, -13 lines) Patch
M ash/touch/touch_uma.cc View 1 2 2 chunks +4 lines, -1 line 0 comments Download
M ui/aura/gestures/gesture_recognizer_unittest.cc View 1 1 chunk +55 lines, -0 lines 0 comments Download
M ui/base/gestures/gesture_point.h View 1 3 chunks +6 lines, -2 lines 0 comments Download
M ui/base/gestures/gesture_point.cc View 1 5 chunks +19 lines, -8 lines 0 comments Download
M ui/base/gestures/gesture_sequence.cc View 1 chunk +6 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
Yufeng Shen (Slow to review)
7 years, 6 months ago (2013-05-27 21:36:32 UTC) #1
sadrul
https://codereview.chromium.org/16018006/diff/1/ui/aura/gestures/gesture_recognizer_unittest.cc File ui/aura/gestures/gesture_recognizer_unittest.cc (right): https://codereview.chromium.org/16018006/diff/1/ui/aura/gestures/gesture_recognizer_unittest.cc#newcode2969 ui/aura/gestures/gesture_recognizer_unittest.cc:2969: root_window()->AsRootWindowHostDelegate()->OnHostTouchEvent(&release2); check tap_count here and after the first tap ...
7 years, 6 months ago (2013-05-28 17:48:46 UTC) #2
Yufeng Shen (Slow to review)
https://codereview.chromium.org/16018006/diff/1/ui/aura/gestures/gesture_recognizer_unittest.cc File ui/aura/gestures/gesture_recognizer_unittest.cc (right): https://codereview.chromium.org/16018006/diff/1/ui/aura/gestures/gesture_recognizer_unittest.cc#newcode2969 ui/aura/gestures/gesture_recognizer_unittest.cc:2969: root_window()->AsRootWindowHostDelegate()->OnHostTouchEvent(&release2); On 2013/05/28 17:48:46, sadrul wrote: > check tap_count ...
7 years, 6 months ago (2013-05-28 19:31:44 UTC) #3
sadrul
LGTM
7 years, 6 months ago (2013-05-28 19:53:14 UTC) #4
Yufeng Shen (Slow to review)
cc sky@ for OWNER of ash/touch/touch_uma.h
7 years, 6 months ago (2013-05-28 20:01:57 UTC) #5
sky
LGTM https://codereview.chromium.org/16018006/diff/6001/ash/touch/touch_uma.cc File ash/touch/touch_uma.cc (right): https://codereview.chromium.org/16018006/diff/6001/ash/touch/touch_uma.cc#newcode205 ash/touch/touch_uma.cc:205: else if (tap_count == 2) nit: style guide ...
7 years, 6 months ago (2013-05-28 21:08:37 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/miletus@chromium.org/16018006/7006
7 years, 6 months ago (2013-05-28 21:19:25 UTC) #7
commit-bot: I haz the power
7 years, 6 months ago (2013-05-29 01:22:47 UTC) #8
Message was sent while issue was closed.
Change committed as 202735

Powered by Google App Engine
This is Rietveld 408576698