Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(594)

Issue 16014003: Adjust style of the popup dialogs's title in Files.app. (Closed)

Created:
7 years, 6 months ago by mtomasz
Modified:
7 years, 6 months ago
CC:
chromium-reviews, rginda+watch_chromium.org, arv+watch_chromium.org
Visibility:
Public.

Description

Adjust style of the popup dialogs's title in Files.app. This patch makes the title no bold and 15 pixels size to match the recent specs. TBR=yoshiki@chromium.org TEST=Tested manually. Invoke the open with dialog on a file which has more than one handler. BUG=239304 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=202830

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M chrome/browser/resources/file_manager/css/common.css View 1 chunk +1 line, -2 lines 1 comment Download

Messages

Total messages: 8 (0 generated)
mtomasz
@hirono: PTAL at this tiny patch. Thanks.
7 years, 6 months ago (2013-05-29 03:53:21 UTC) #1
hirono
https://chromiumcodereview.appspot.com/16014003/diff/1/chrome/browser/resources/file_manager/css/common.css File chrome/browser/resources/file_manager/css/common.css (right): https://chromiumcodereview.appspot.com/16014003/diff/1/chrome/browser/resources/file_manager/css/common.css#newcode661 chrome/browser/resources/file_manager/css/common.css:661: font-size: 125%; Cannot we specify the direct value '15px'?
7 years, 6 months ago (2013-05-29 04:03:02 UTC) #2
mtomasz
On 2013/05/29 04:03:02, hirono wrote: > https://chromiumcodereview.appspot.com/16014003/diff/1/chrome/browser/resources/file_manager/css/common.css > File chrome/browser/resources/file_manager/css/common.css (right): > > https://chromiumcodereview.appspot.com/16014003/diff/1/chrome/browser/resources/file_manager/css/common.css#newcode661 > ...
7 years, 6 months ago (2013-05-29 04:05:45 UTC) #3
hirono
On 2013/05/29 04:05:45, mtomasz wrote: > On 2013/05/29 04:03:02, hirono wrote: > > > https://chromiumcodereview.appspot.com/16014003/diff/1/chrome/browser/resources/file_manager/css/common.css ...
7 years, 6 months ago (2013-05-29 04:09:27 UTC) #4
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
7 years, 6 months ago (2013-05-29 04:15:13 UTC) #5
mtomasz
On 2013/05/29 04:09:27, hirono wrote: > On 2013/05/29 04:05:45, mtomasz wrote: > > On 2013/05/29 ...
7 years, 6 months ago (2013-05-29 04:17:01 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mtomasz@chromium.org/16014003/1
7 years, 6 months ago (2013-05-29 04:17:32 UTC) #7
commit-bot: I haz the power
7 years, 6 months ago (2013-05-29 08:58:35 UTC) #8
Message was sent while issue was closed.
Change committed as 202830

Powered by Google App Engine
This is Rietveld 408576698