Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(586)

Issue 16012018: Cleanup: Put DBus unit tests in the dbus namespace, so one does not need to write dbus:: everywhere… (Closed)

Created:
7 years, 6 months ago by Lei Zhang
Modified:
7 years, 6 months ago
Reviewers:
satorux1
CC:
chromium-reviews
Visibility:
Public.

Description

Cleanup: Put DBus unit tests in the dbus namespace, so one does not need to write dbus:: everywhere. Remove some other dbus:: usages in the dbus namespace. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=206010

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+610 lines, -590 lines) Patch
M dbus/bus.cc View 6 chunks +8 lines, -8 lines 0 comments Download
M dbus/bus_unittest.cc View 16 chunks +60 lines, -56 lines 0 comments Download
M dbus/end_to_end_async_unittest.cc View 29 chunks +79 lines, -76 lines 0 comments Download
M dbus/end_to_end_sync_unittest.cc View 5 chunks +36 lines, -32 lines 0 comments Download
M dbus/exported_object.cc View 1 chunk +1 line, -1 line 0 comments Download
M dbus/message.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M dbus/message_unittest.cc View 32 chunks +106 lines, -104 lines 0 comments Download
M dbus/mock_unittest.cc View 10 chunks +36 lines, -33 lines 0 comments Download
M dbus/object_manager_unittest.cc View 8 chunks +82 lines, -85 lines 0 comments Download
M dbus/property_unittest.cc View 7 chunks +27 lines, -23 lines 0 comments Download
M dbus/signal_sender_verification_unittest.cc View 9 chunks +22 lines, -18 lines 0 comments Download
M dbus/string_util_unittest.cc View 1 chunk +18 lines, -14 lines 0 comments Download
M dbus/test_service.cc View 19 chunks +52 lines, -61 lines 0 comments Download
M dbus/values_util_unittest.cc View 15 chunks +79 lines, -75 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Lei Zhang
7 years, 6 months ago (2013-06-11 22:05:57 UTC) #1
satorux1
LGTM. Thanks!
7 years, 6 months ago (2013-06-12 05:48:00 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thestig@chromium.org/16012018/1
7 years, 6 months ago (2013-06-12 19:20:53 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thestig@chromium.org/16012018/1
7 years, 6 months ago (2013-06-13 02:33:07 UTC) #4
commit-bot: I haz the power
7 years, 6 months ago (2013-06-13 06:37:21 UTC) #5
Message was sent while issue was closed.
Change committed as 206010

Powered by Google App Engine
This is Rietveld 408576698