Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(435)

Issue 16010005: Use the all_blink target instead of specifying particular targets inside Blink (Closed)

Created:
7 years, 7 months ago by jamesr
Modified:
7 years, 6 months ago
Reviewers:
abarth-chromium
CC:
chromium-reviews
Visibility:
Public.

Description

Use the all_blink target instead of specifying particular targets inside Blink This is less fragile to target shuffles inside Blink. R=abarth Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=202535

Patch Set 1 #

Total comments: 2

Patch Set 2 : use all_webkit target #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -8 lines) Patch
M build/all.gyp View 1 4 chunks +4 lines, -8 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
jamesr
7 years, 7 months ago (2013-05-28 07:41:07 UTC) #1
abarth-chromium
https://codereview.chromium.org/16010005/diff/1/build/all.gyp File build/all.gyp (right): https://codereview.chromium.org/16010005/diff/1/build/all.gyp#newcode418 build/all.gyp:418: '../third_party/WebKit/public/all.gyp:all_blink', # to run layout tests This doesn't pull ...
7 years, 7 months ago (2013-05-28 07:46:18 UTC) #2
jamesr
https://codereview.chromium.org/16010005/diff/1/build/all.gyp File build/all.gyp (right): https://codereview.chromium.org/16010005/diff/1/build/all.gyp#newcode418 build/all.gyp:418: '../third_party/WebKit/public/all.gyp:all_blink', # to run layout tests On 2013/05/28 07:46:18, ...
7 years, 7 months ago (2013-05-28 07:55:09 UTC) #3
abarth-chromium
LGTM
7 years, 7 months ago (2013-05-28 07:56:58 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamesr@chromium.org/16010005/3003
7 years, 7 months ago (2013-05-28 08:10:33 UTC) #5
commit-bot: I haz the power
7 years, 6 months ago (2013-05-28 11:44:59 UTC) #6
Message was sent while issue was closed.
Change committed as 202535

Powered by Google App Engine
This is Rietveld 408576698