Issue 16010004: Tag smi-constants as smi.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 16010004: Tag smi-constants as smi. (Closed)

Created:
7 years, 6 months ago by Toon Verwaest

Modified:
7 years, 6 months ago

Reviewers:
Jakob Kummerow

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Tag smi-constants as smi. R=jkummerow@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=14834

Patch Set 1 #

Created: 7 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -1 line)			Patch
	M	src/hydrogen-instructions.cc	View		1 chunk	+3 lines, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Toon Verwaest

Committed patchset #1 manually as r14834 (presubmit successful).

7 years, 6 months ago (2013-05-28 08:00:47 UTC) #3

Sven Panne

This breaks make arm.debug.check TESTJOBS=mjsunit/external-array-no-sse2 Is there a fix or should we revert this CL?

7 years, 6 months ago (2013-05-29 11:43:02 UTC) #4

Jakob Kummerow

7 years, 6 months ago (2013-05-29 11:47:23 UTC) #5

Message was sent while issue was closed.

On 2013/05/29 11:43:02, Sven Panne wrote:
> This breaks
> 
>    make arm.debug.check TESTJOBS=mjsunit/external-array-no-sse2
> 
> Is there a fix or should we revert this CL?

The failure seems benign, as in "outdated and therefore overly aggressive
ASSERT". s/IsTagged()/IsSmiOrTagged()/ in lithium-arm.cc:2038 should fix it.

Expand Messages | Collapse Messages