Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Unified Diff: content/public/browser/download_item.h

Issue 16007017: [Resumption 10/12] Use DI::IsDone to check for terminal downloads. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Merge with r204343 Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/public/browser/download_item.h
diff --git a/content/public/browser/download_item.h b/content/public/browser/download_item.h
index 6c9011007e308591230732608bfe87f18653facc..b0ea0c98387a9fcc655e8099a2fb92e79cf0315c 100644
--- a/content/public/browser/download_item.h
+++ b/content/public/browser/download_item.h
@@ -170,10 +170,12 @@ class CONTENT_EXPORT DownloadItem : public base::SupportsUserData {
// user-interaction to resume.
virtual bool CanResume() const = 0;
- // Convenience routines for accessing GetState() results conceptually -----
+ // Returns true if the download is in a terminal state. This includes
+ // completed downloads, cancelled downloads, and interrupted downloads that
+ // can't be resumed.
+ virtual bool IsDone() const = 0;
- // Returns true if the download needs more data.
- virtual bool IsPartialDownload() const = 0;
+ // Convenience routines for accessing GetState() results conceptually -----
// Returns true if the download is still receiving data.
virtual bool IsInProgress() const = 0;
« no previous file with comments | « content/browser/download/download_manager_impl_unittest.cc ('k') | content/public/test/download_test_observer.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698