chrome/browser/ui/webui/downloads_dom_handler.cc - Issue 16007017: [Resumption 10/12] Use DI::IsDone to check for terminal downloads.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/downloads_dom_handler.cc

Issue 16007017: [Resumption 10/12] Use DI::IsDone to check for terminal downloads. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Merge with r204343 Created 7 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/webui/downloads_dom_handler.cc

diff --git a/chrome/browser/ui/webui/downloads_dom_handler.cc b/chrome/browser/ui/webui/downloads_dom_handler.cc

index 47fb18dbf489116b7da0142541af3bc7985451bf..ed033099fe6450321eb9a48b59cd137b01c32617 100644

--- a/chrome/browser/ui/webui/downloads_dom_handler.cc

+++ b/chrome/browser/ui/webui/downloads_dom_handler.cc

@@ -510,7 +510,7 @@ void DownloadsDOMHandler::DangerPromptAccepted(int download_id) {

item = main_notifier_.GetManager()->GetDownload(download_id);

if (!item && original_notifier_.get() && original_notifier_->GetManager())

item = original_notifier_->GetManager()->GetDownload(download_id);

- if (!item || (item->GetState() != content::DownloadItem::IN_PROGRESS))

+ if (!item || item->IsDone())

return;

CountDownloadsDOMEvents(DOWNLOADS_DOM_EVENT_SAVE_DANGEROUS);

item->ValidateDangerousDownload();