Issue 16007010: Fix vertical alignment in the rename field in Files.app.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 16007010: Fix vertical alignment in the rename field in Files.app. (Closed)

Created:
7 years, 6 months ago by mtomasz

Modified:
7 years, 6 months ago

Reviewers:
commit-bot: I haz the power, hirono

CC:
chromium-reviews, rginda+watch_chromium.org, arv+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Fix vertical alignment in the rename field in Files.app. This patch replaces line-height with padding to avoid an ugly, not centered selection. TBR=yoshiki@chromium.org TEST=Go to Files.app, edit a file. BUG=239305 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=202813

Created: 7 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -2 lines)			Patch
	M	chrome/browser/resources/file_manager/css/file_manager.css	View		1 chunk	+1 line, -2 lines	0 comments	Download

Total messages: 5 (0 generated)

hirono

On 2013/05/29 04:03:28, mtomasz wrote: > @hirono: PTAL at this trivial cl. Thanks! lgtm!

7 years, 6 months ago (2013-05-29 04:05:02 UTC) #2

commit-bot: I haz the power

No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...

7 years, 6 months ago (2013-05-29 04:06:13 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mtomasz@chromium.org/16007010/1

7 years, 6 months ago (2013-05-29 04:07:00 UTC) #4

Message was sent while issue was closed.

Change committed as 202813